Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yield_receiver_to_any_instance_implementation_blocks configuration only when necessary in RSpec 2.99 #56

Closed
yujinakayama opened this issue Mar 27, 2014 · 4 comments

Comments

@yujinakayama
Copy link
Owner

No description provided.

@myronmarston
Copy link

I was just going to open an issue about this and noticed this one :).

Besides the fact that it appears to always be added, I'm seeing it get added multiple times, once per RSpec.configure block (I commonly use RSpec.configure in multiple files).

@yujinakayama
Copy link
Owner Author

I'm seeing it get added multiple times, once per RSpec.configure block (I commonly use RSpec.configure in multiple files).

I'm aware of it, but it's difficult for Transpec to determine which RSpec.configure is the main one.

@myronmarston
Copy link

I'm aware of it, but it's difficult for Transpec to determine which RSpec.configure is the main one.

Putting on only one configuration block that isn't the main one is better than putting it on all of them, IMO. Also, maybe this could work as a simple heuristic when doing runtime analysis? Pick whichever RSpec.configure block is run first as the main one?

@yujinakayama
Copy link
Owner Author

It seems reasonable. I'll try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants