Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect URL for streaming API #16

Closed
Johann150 opened this issue Jan 31, 2023 · 3 comments · Fixed by #17
Closed

incorrect URL for streaming API #16

Johann150 opened this issue Jan 31, 2023 · 3 comments · Fixed by #17
Assignees
Labels
bug Something isn't working

Comments

@Johann150
Copy link

The framework uses an incorrect URL for the streaming API. The streaming API documentation can be found at: https://misskey-hub.net/docs/api/streaming

wrong: wss://misskey.example/?i={token}
correct: wss://misskey.example/streaming?i={token}

I think this line needs to be changed:

f'{client.url}?i={client.token}'

It only works because Misskey is currently permissive about which URL you use. Foundkey (a fork of Misskey) is more restrictive and only allows the path /streaming that is defined in the documentation.

normikoto added a commit to normikoto/MiPA that referenced this issue Jan 31, 2023
This updates the streaming url used to match that of the Misskey API docs at https://misskey-hub.net/docs/api/streaming/

Resolves yupix#16
@yupix yupix self-assigned this Feb 1, 2023
@yupix yupix added the bug Something isn't working label Feb 1, 2023
@yupix
Copy link
Owner

yupix commented Feb 1, 2023

Thanks for the report. I think this is probably a bug because the design was initially based on the assumption that URLs would be received in the wss//example.com/streaming format.

@yupix yupix closed this as completed in #17 Feb 1, 2023
@yupix yupix reopened this Feb 1, 2023
@yupix
Copy link
Owner

yupix commented Feb 1, 2023

I just remembered that in pull request #17, if you include streaming in the url, it may not work correctly as streamingstreaming. Please wait a while until this is resolved.

@yupix yupix closed this as completed in a7837b7 Feb 1, 2023
@yupix
Copy link
Owner

yupix commented Feb 1, 2023

In fixing this bug, we also fixed a bug that caused an error if there was a trailing /, such as https://example.com/. Thank you again for your report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants