Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree mode optimization #15

Closed
YuriGor opened this issue Apr 18, 2019 · 0 comments
Closed

Tree mode optimization #15

YuriGor opened this issue Apr 18, 2019 · 0 comments

Comments

@YuriGor
Copy link
Owner

YuriGor commented Apr 18, 2019

Now in the tree mode deepdash walks over all the nested fields and checks each path of it matches given 'children' criteria, because children path may be configured as a regexp, and it's impossible to say beforehand which nested value is a children collection, until we build and tested it's path.

Regexp support in the 'children' option should be dropped as an overkill. If only constant paths will be allowed, we will be able to go and get children collection directly, without bruteforcing all the possible variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant