Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera is dark due to FPSrate #193

Open
Thomas-Pronovost92 opened this issue Dec 9, 2023 · 0 comments
Open

Camera is dark due to FPSrate #193

Thomas-Pronovost92 opened this issue Dec 9, 2023 · 0 comments

Comments

@Thomas-Pronovost92
Copy link

Thomas-Pronovost92 commented Dec 9, 2023

Hi!
I recently tried to integrate this code scanner to my project (v2.3.2). The preview of the camera is dark however on one of my test device a Fire HD 10 tablet.

I think that I have narrowed the issue down to the FPS rate, the one selected being [3000, 3000] (same value for max and min)
In my way to implement a fix, I found that the classes are all final, thus untouchable unless I copy the project in my app, which I would like to avoid)

Here is the fix that worked for me (when I copied your project in my app:
In Utils.configureFpsRange - > adding fpsRange[Parameters.PREVIEW_FPS_MIN_INDEX] != fpsRange[Parameters.PREVIEW_FPS_MAX_INDEX] in the if statement resolved the issue

So is there a reason why all classes are final? And would it be possible to remove this feature?
Also, maybe a method could be added to select the FPSrate?

@Thomas-Pronovost92 Thomas-Pronovost92 changed the title cannot extends module classes Camera is dark due to FPSrate, but nothing can be changed from my side since classes are final Dec 9, 2023
@Thomas-Pronovost92 Thomas-Pronovost92 changed the title Camera is dark due to FPSrate, but nothing can be changed from my side since classes are final Camera is dark due to FPSrate Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant