Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove to access repositories from schedule usecases #211

Closed
YutoMizutani opened this issue Dec 2, 2018 · 1 comment
Closed

Remove to access repositories from schedule usecases #211

YutoMizutani opened this issue Dec 2, 2018 · 1 comment
Labels
WIP Work in progress

Comments

@YutoMizutani
Copy link
Owner

No description provided.

@YutoMizutani YutoMizutani added the WIP Work in progress label Dec 2, 2018
@YutoMizutani
Copy link
Owner Author

問題

例として，
let schedule: ScheduleUseCase = DiscreteTrialUseCase(Alt(FT(5), CRF()))
の場合，extendEntityの更新にはrepositoryのupdateExtendEntityを呼ぶ必要があり，subschedule(s)が内部に複数のsubscheduleを持つcompound scheduleの場合，各usecaseにプロパティが反映されない問題が発生する。

解決方法

原則としてrepositoryからアクセスできないよう， protocol ScheduleUseCase からrepositoryを除外する必要がある

YutoMizutani added a commit that referenced this issue Dec 3, 2018
@YutoMizutani
🎉 Remove repository access from usecases #211
d0cbb81
YutoMizutani added a commit that referenced this issue Dec 3, 2018
@YutoMizutani
🎉 Update schedule usecases #211
76cc6bc
@YutoMizutani YutoMizutani mentioned this issue Dec 3, 2018
Merged
YutoMizutani added a commit that referenced this issue Dec 3, 2018
@YutoMizutani
Merge pull request #218 from /issues/211
abf793b 
Issues/211
YutoMizutani added a commit that referenced this issue Dec 4, 2018
@YutoMizutani
🔥 Remove unused data stores #211
029ecac
YutoMizutani added a commit that referenced this issue Dec 4, 2018
@YutoMizutani
👍 Improve self capture where view outputs #211
52de724
YutoMizutani added a commit that referenced this issue Dec 4, 2018
@YutoMizutani
🐛 Fix to public #211
d0ed8ab
YutoMizutani added a commit that referenced this issue Dec 4, 2018
@YutoMizutani
🐛 Fix to the hot/cold issue #211
a8ad9ba
YutoMizutani added a commit that referenced this issue Dec 4, 2018
@YutoMizutani
🐛 Fix resettable variables #211
04b3dd2
YutoMizutani added a commit that referenced this issue Dec 4, 2018
@YutoMizutani
🐛 Remove comments #211
e0ec107
@YutoMizutani YutoMizutani mentioned this issue Dec 4, 2018
Merged
YutoMizutani added a commit that referenced this issue Dec 4, 2018
@YutoMizutani
Merge pull request #220 from /issues/211
9ac7e86 
Issues/211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YutoMizutani