You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, it feels like migrations are not applied in a transaction and as such could make the database inconsistent and unusable if a migration has failed. This should be improved.
To make sure migrations are applied in a specific order, it will be better to accept an array of migrations dir instead of an unordered map:
Looks like migrations are applied in a transaction but if it fails, go-migrate will still set the version to the failed one with the dirty flag set to 1 so a user intervention is necessary.
I'm not sure about this but migrations should not fail in a release environment, so maybe that's pointless after all. Migrations could fail when developping but that's all.
At the moment, it feels like migrations are not applied in a transaction and as such could make the database inconsistent and unusable if a migration has failed. This should be improved.
To make sure migrations are applied in a specific order, it will be better to accept an array of migrations dir instead of an unordered map:
seelf/pkg/storage/sqlite/database.go
Line 67 in 1eba5d9
The text was updated successfully, but these errors were encountered: