Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About sampler #38

Closed
signofyouth opened this issue Nov 23, 2020 · 2 comments
Closed

About sampler #38

signofyouth opened this issue Nov 23, 2020 · 2 comments

Comments

@signofyouth
Copy link

Thank you for your great work. I'm very interested in your paper.

When trying your code, I found RandomMultipleGallerySampler sometimes gives an ID which contains only 1 instance in a batch.
This is because 1 instance pushed in 'ret' at line 74 was remained even when continued at https://github.com/yxgeee/MMT/blob/master/mmt/utils/data/sampler.py#L93.

Would you check and fix it? Thank you.

@yxgeee
Copy link
Owner

yxgeee commented Nov 23, 2020

Yes, but it is not a bug here. Does it cause any running issues in your experiments?

@signofyouth
Copy link
Author

signofyouth commented Nov 23, 2020

Thank you for your quick reply.

No, errors does not occur when running on your code. And the result does not change as far as I tried.
However, it's a little uncomfortable that the sampling policy(4 instances per ID) would not always work.

Anyway, you're right it is not a bug here. Please close this issue.

@yxgeee yxgeee closed this as completed Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants