Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 cases in test_device.py failed on FreeBSD #1

Closed
yzgyyang opened this issue Jul 21, 2017 · 2 comments
Closed

2 cases in test_device.py failed on FreeBSD #1

yzgyyang opened this issue Jul 21, 2017 · 2 comments

Comments

@yzgyyang
Copy link
Owner

tests/comparators/test_device.py::test_diff FAILED
tests/comparators/test_device.py::test_diff_reverse FAILED

The reason being that the expected output assumed that /dev/null should always have .major:1 .minor:3, however, in FreeBSD,

➜  ~ python3
Python 3.6.2 (default, Jul 18 2017, 01:40:45) 
[GCC 4.2.1 Compatible FreeBSD Clang 4.0.0 (tags/RELEASE_400/final 297347)] on freebsd12
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> st = os.lstat('/dev/null')
>>> os.major(st.st_rdev)
0
>>> os.minor(st.st_rdev)
14
@yzgyyang
Copy link
Owner Author

yzgyyang commented Jul 21, 2017

Fixed in a5d7a19. A patch is also been created:
diffoscope_test_device_patch.diff.txt

@emaste @mapreri

@yzgyyang
Copy link
Owner Author

Committed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant