Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Pkl Type Implementations #8

Closed
5 tasks done
z-jxy opened this issue Jun 28, 2024 · 0 comments · Fixed by #9
Closed
5 tasks done

Missing Pkl Type Implementations #8

z-jxy opened this issue Jun 28, 2024 · 0 comments · Fixed by #9

Comments

@z-jxy
Copy link
Owner

z-jxy commented Jun 28, 2024

There's a few pkl types that haven't been implemented. I think most of these could be represented by the type system or creating a struct for them. Will also need to add deserializers for these types

  • DURATION => std::time::Duration
  • DATA_SIZE => rpkl::value::DataSize
  • PAIR => tuple with 2 elements
    • This causes PklValue to have infinite size (fixed by storing in a Box)
  • INT_SEQ => std::ops::Range<i64>
  • REGEX => added Regex(String) variant to PklValue/Value
    TYPE_ALIAS => doesn't appear in the evaluated module response, so this can be ignored

These should be added as variants to PklValue.

@z-jxy z-jxy mentioned this issue Jun 28, 2024
@z-jxy z-jxy linked a pull request Jul 18, 2024 that will close this issue
@z-jxy z-jxy closed this as completed in #9 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant