Add Zen Nodes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egyptianbman
commented
Jul 21, 2018
lib/jobManager.js
Outdated
| options.coin.percentSecureNodesReward, | ||
| options.coin.vSecureNodesRewardAddress, | ||
| options.coin.percentSuperNodesReward, | ||
| options.coin.vSuperNodesRewardAddress |
There was a problem hiding this comment.
(unrelated) I think the lack of overwinter being here might be the reason we're seeing random failed VOT blocks.
There was a problem hiding this comment.
@egyptianbman lack of overwinter option being in the JobManager options?
GaryChicago
suggested changes
Jul 24, 2018
There was a problem hiding this comment.
> z-nomp@0.0.9 start /home/zpooladmin/z-nomp
> LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/node_modules/stratum-pool/node_modules/equihashverify/build/Release/:$PWD/node_modules/equihashverify/build/Release/ node init.js
/home/zpooladmin/z-nomp/node_modules/stratum-pool/lib/transactions.js:256
} else {
^^^^
SyntaxError: Unexpected token else
at createScript (vm.js:80:10)
at Object.runInThisContext (vm.js:139:10)
at Module._compile (module.js:616:28)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object.<anonymous> (/home/zpooladmin/z-nomp/node_modules/stratum-pool/lib/blockTemplate.js:4:20)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! z-nomp@0.0.9 start: `LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/node_modules/stratum-pool/node_modules/equihashverify/build/Release/:$PWD/node_modules/equihashverify/build/Release/ node init.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the z-nomp@0.0.9 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/zpooladmin/.npm/_logs/2018-07-24T12_54_13_518Z-debug.log
Error on npm start. Will add more details add I look into it.
GaryChicago
suggested changes
Jul 24, 2018
It was a bit tricky to get ZEN to work as expected. In the process of working through the issues, I refactored some of the code (initial refactoring) and updated the packages.
egyptianbman
force-pushed
the
feature/add-zen
branch
from
5ed70aa
to
36443ba
Compare
|
This PR goes hand-in-hand with s-nomp/s-nomp#17 To test this properly, you need to make sure you update z-nomp's package.json to point to this branch instead of pulling from master. I still need to test some other coins. With these changes. Testing progress:
|
|
@egyptianbman I'll give zencash another test tonight and I will move ont to bitcoinz and snowgem. I'll approve once someone can test safecoin. |
|
I've successfully tested Zencash (supernodes), Snowgem (masternodes) and BitcoinZ (neither). All were able to find blocks without issue. |
GaryChicago
approved these changes
Jul 31, 2018
|
My tests were successful on testnets. Feel free to merge. |
egyptianbman
added a commit
to s-nomp/s-nomp
that referenced
this pull request
Jul 31, 2018
This commit updates the ZEN configuration to support supernodes. In addition, to get everything working properly, I had to update all the packages. This is actually something I was planning on doing anyway since it seems there are some vulnerabilities with some of these older packages. This commit has a sister commit: s-nomp/node-stratum-pool#2 Please note that since this requires an update to node-stratum-pool that you need to `npm upgrade`. Verify that the latest has been pulled down by checking `node_modules/stratum-pool/lib/transactions.js` has `Super Nodes` in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't had a chance to test this yet but there quite a few merge conflicts and I wouldn't be surprised if there are issues. If you have testnet nodes for ZEN among other coins, please do some testing. Otherwise, I'll test it later this weekend.