Skip to content
This repository has been archived by the owner on Nov 27, 2020. It is now read-only.

[RFC] Handle full PR URLs and not only #NUMBER #18

Closed
fgrehm opened this issue Apr 20, 2018 · 3 comments
Closed

[RFC] Handle full PR URLs and not only #NUMBER #18

fgrehm opened this issue Apr 20, 2018 · 3 comments

Comments

@fgrehm
Copy link

fgrehm commented Apr 20, 2018

Hey @ahmed-taj,

We just installed the app for our org and one thing we noticed is that the bot only matches on #PR_NUMBER. If I got it right, I tracked it down to this regex:

https://github.com/ahmed-taj/dep/blob/999cc9bf74059404321d8323403c7ffac38f9a05/lib/helpers/match.js#L1

Would you be open to expanding that to support full links to PRs / issues?

@z0al
Copy link
Owner

z0al commented Apr 20, 2018

Hey @fgrehm, thanks for giving DEP a try!

Actually, I will support full links to PRs / issues since I'm planning to support cross-repository dependencies (#2). I will work on that soon :)

@colindean
Copy link

I got bit by this just now trying out DEP for the first time. I tried using a short reference like org/repo#1 to reference another private repo that DEP has permission to access. DEP cleared it when it was not actually OK to do so.

@z0al
Copy link
Owner

z0al commented Nov 25, 2020

Hey @colindean I hope you are doing well.

I was able to build a new GitHub action to replaces this bot.

The new action is more robust and has a few more features like customizing the keywords, label, and supporting dependencies from any repository. It can also handle references like e.g. user/repo#1 🎉

Please check it out at https://github.com/z0al/dependent-issues

This bot is now deprecated and I will be archiving this repository in the upcoming days. Thanks.

@z0al z0al closed this as completed Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants