-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video open close loop when using ani-cli hook #637
Comments
Trackma just runs the command |
Here is a video of how it looks, as well as how my task manager looks during that time, and then how ani-cli runs the command fine by itself. 2022-08-21_07-47-52.mp4I don't really know how to code, but I managed to replace ani-cli in the python hook with animdl. I had to default an index choice for it to work so it gives the wrong episode a lot. I don't exactly consider it a good alterative, but it doesn't seem to have the same problem that ani-cli is giving. This leads me to think that maybe it is some problem with the interaction between trackma and ani-cli. Or at least in my case. Edit: Alright, I commented out the menu loop that appears and holds the terminal while you are playing an episode using ani-cli, and now it seems to work like it should for play in trackma.
I don't know any coding so not sure how you go from here, just figured it might be useful. |
Put in a request over at |
Can confirm issue / unintended usage on our end. |
It looks to me as if the |
As a temporal fix, I edited the script for it to open ani-cli through the terminal of my choice, in this case alacritty. Only noticeable edits are using import shutil
import os
from trackma import utils
# Executed when trying to watch an episode that doesn't exist in your library
def episode_missing(engine, show, episode):
query = show["title"].strip()
anicli = shutil.which("ani-cli") # find 'ani-cli' executable
if anicli:
args = ["alacritty -e", anicli, "-q", "best", "-a", str(episode), query]
cmd = " ".join(args[:-1]) + f" '{query}'"
engine.msg.info("episode_missing", cmd) # Show the command used
#utils.spawn_process(args)
os.system(cmd)
else:
engine.msg.info("episode_missing", "ani-cli was not found")``` |
It's unfortunate ani-cli intentions to remove the A long term support would be to change it for another program, since it would be quite a pain to use then. I can reproduce the bug with this on the terminal:
Since ani-cli loads the next episode when you press This will solve the problem on the terminal:
This will input the letter |
Fixed on #652 |
Btw ani-cli has full support for non-interactive usage again. A python wrapper is a bad idea. |
We actually still open a menu after the episode has played. |
@port19x Isn't that arguably a even better solution than just quitting the program after the episode is done? And when you don't have rofi installed, it just closes, like previously intended too Test it with |
In fact, it would be probably better to not specify -S 1 by default, only when rofi is not installed, because the user can select the correct anime to watch. This is a deal breaker for me, personally I almost never used this script that i made, because it most often fails to select the correct anime (and the poor bit rate) This is specially true if you want to watch a anime with more than 1 season or with specials. If you search for Death Note, the last entry will be the actual anime. It's actually rare to find anime where this doesn't happen, like One Piece, or anime airing for the first time recently. |
I updated #652 to the new 4.2 version. It's pretty satisfactory now, specially if you have rofi installed. |
So whenever I try and use the ani-cli hook, it launches the player and closes it over and over again until it has cycled through all the episodes of the series. Sometimes it is open long enough for me to see a second or 2 of the actual show playing.
I am on Arch linux, and it was installed with the use of the AUR trackma-git package.
Playing files on the seems to work okay.
I tried to change over to to auto for the tracker, but it had the same video window opening and closing but didn't have as much to say with -d as mpris.
It goes down like that until the episodes run out.
The text was updated successfully, but these errors were encountered: