Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info.md #94

Open
tensiondriven opened this issue Feb 4, 2024 · 1 comment
Open

Update info.md #94

tensiondriven opened this issue Feb 4, 2024 · 1 comment

Comments

@tensiondriven
Copy link

Loving the integration! This is a nice piece of work and far superior to the "builtin" Omada integration.

I just noticed that the content of info.md seems to be out of date with README.md. This issue is just a note to potentially update it.

I'd also love to see some more elaboration in info.md about the differences between the builtin Omada integration and this one, so n00bs would have a better chance of differentiating them. (I'd submit a PR for this but amn't able at the moment, just wanted to log this issue in case I can't get back to it.)

Another idea might be to link to info.md from README.md and then keep info.md up to date as the source of truth to prevent it from falling out of sync in the future.

While I'm ranting, it would be great to have a table of gateways/versions/firmwares that are known good / known not-so-good, since it's not too surprising that different routers/gateways/controllers etc expose radically different sensors.

Brilliant integration, much needed. I especially appriciate the configuration options to enable/disable the device trackers, etc.

@fplanque
Copy link
Contributor

fplanque commented Feb 7, 2024

I edited and made a pull request for what you proposed.

#95

I also want to +1 on the statements that this integration is brilliant, much needed and superior to the built in one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants