Add handling covering incr/3 on non-numeric keys #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's a bug in
decr/3
andincr/3
in that if you create a non-numeric value beforehand, a call to either will crash the server.This PR will add coverage around this issue and resolve it in all workers. I also added handling to
get_and_update/4
to better support transactions and unrecognised errors.You can now
Cachex.abort(worker, :reason)
from inside aget_and_update/4
call to exit early and not commit the changes, and{ :error, :reason }
will be returned.