Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback transaction #20

Closed
AlbertoDePena opened this issue Aug 24, 2021 · 2 comments
Closed

Rollback transaction #20

AlbertoDePena opened this issue Aug 24, 2021 · 2 comments

Comments

@AlbertoDePena
Copy link

Do you think the executeTransaction and executeTransactionAsync methods should roll back the transaction when an error occurs? Unless the disposing of the Connection does the trick?
@Zaid-Ajaj
Copy link
Owner

Well, the transaction doesn't commit unless everything works as expected, so is the rollback necessary in this case?

@AlbertoDePena
Copy link
Author

That is a great question... I'll have to do some digging into it! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zaid-Ajaj @AlbertoDePena