Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit image metainfo #114

Open
lpatiny opened this issue May 17, 2024 · 4 comments · May be fixed by #123
Open

Edit image metainfo #114

lpatiny opened this issue May 17, 2024 · 4 comments · May be fixed by #123
Assignees

Comments

@lpatiny
Copy link
Contributor

lpatiny commented May 17, 2024

There should be an edit button on each row of the images:

image

That allows to edit metadata information.

      "metadata": {
        "name": "Silica_small.tif",
        "relativePath": "Fribourg/Silica_small.tif"
      },

There should be 2 metadata information currently:

  • name
  • pixelSize

pixelSize should be defined as a number + units. Like '1 mm' and corresponds to the size of 1 pixel.

We will see later to convert this using js-quantities.

@lpatiny
Copy link
Contributor Author

lpatiny commented May 17, 2024

The type of 'pixelSize' should be: https://github.com/cheminfo/cheminfo-types/blob/main/src/core/Value.d.ts

The allowed units could be for now: nm, µm, mm, m, km

You can use 'input group' to input the value

https://blueprintjs.com/docs/#core/components/input-group

image

@moonayyur
Copy link
Collaborator

moonayyur commented May 28, 2024

pixelSize should be defined as a number + units. Like '1 mm' and corresponds to the size of 1 pixel.

@lpatiny Should the pixel value and unit be saved in the same metadata ?
I think it would be easier for the display and data editing if they are saved separately

      "metadata": {
        "name": "Silica_small.tif",
        "relativePath": "Fribourg/Silica_small.tif"
        "pixelSize": "0.272727272727"
        "pixelUnit": "nm"
      },

@lpatiny
Copy link
Contributor Author

lpatiny commented May 30, 2024

I would prefer it is saved in the same metadata but you are right that we didn't develop a way to display it so you can for now use 2 fields.

@lpatiny
Copy link
Contributor Author

lpatiny commented May 30, 2024

Please add a 's' at units. pixelUnits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants