[1/3] Add test suite dedicated for configuration resources #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linki
force-pushed
the
configuration-resources-tests
branch
5 times, most recently
from
1b895ce
to
fef68aa
Compare
linki
force-pushed
the
configuration-resources-tests
branch
from
fef68aa
to
5033282
Compare
linki
force-pushed
the
configuration-resources-tests
branch
from
5033282
to
d9910de
Compare
linki
force-pushed
the
custom-configmap-refs
branch
2 times, most recently
from
7c700d3
to
01e9152
Compare
linki
force-pushed
the
configuration-resources-tests
branch
from
d9910de
to
7113886
Compare
linki
changed the title
gargravarr
reviewed
Mar 5, 2024
linki
changed the title
This was referenced Mar 7, 2024
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate test suite to focus on versioned configuration resources where we don't need to care (as much) about all that other stuff that StackSets can have.
The rewrite of the existing tests using the new methods to make sure everything still works was done in #606. Some of these could be removed as the behaviour is tested in this new suite as well but we can also leave them.
Please also see the follow up PRs that are based on this one: