[3/3] Add e2e test case for Inline ConfigMaps #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linki
changed the title
linki
force-pushed
the
configuration-resources-simpler-tests
branch
5 times, most recently
from
da8bfe4
to
927ee92
Compare
linki
force-pushed
the
configmap-inline-another-try
branch
3 times, most recently
from
9c57062
to
f732160
Compare
linki
force-pushed
the
configmap-inline-another-try
branch
2 times, most recently
from
bb4468a
to
ee45eb2
Compare
linki
force-pushed
the
configuration-resources-simpler-tests
branch
2 times, most recently
from
1f00726
to
5f1b128
Compare
linki
changed the title
This was referenced Mar 7, 2024
linki
force-pushed
the
configuration-resources-simpler-tests
branch
from
5f1b128
to
ab00360
Compare
linki
force-pushed
the
configmap-inline-another-try
branch
from
ee45eb2
to
d24e5a4
Compare
linki
force-pushed
the
configuration-resources-simpler-tests
branch
2 times, most recently
from
11f0961
to
3c22661
Compare
linki
force-pushed
the
configmap-inline-another-try
branch
2 times, most recently
from
df18af0
to
b6abb34
Compare
linki
force-pushed
the
configuration-resources-simpler-tests
branch
from
3c22661
to
bc0ed5c
Compare
linki
force-pushed
the
configmap-inline-another-try
branch
from
b6abb34
to
19a2f7a
Compare
linki
force-pushed
the
configuration-resources-simpler-tests
branch
from
bc0ed5c
to
19c0e76
Compare
linki
force-pushed
the
configuration-resources-simpler-tests
branch
from
19c0e76
to
5242530
Compare
linki
force-pushed
the
configuration-resources-simpler-tests
branch
from
5242530
to
eae7cce
Compare
* Update dependencies (k8s.io/* -> v0.26.14) Signed-off-by: Zak Lawrence <zaklawrencea@protonmail.com> * Handle informer error Signed-off-by: Zak Lawrence <zaklawrencea@protonmail.com> * Update error strings Signed-off-by: Zak Lawrence <zaklawrencea@protonmail.com> --------- Signed-off-by: Zak Lawrence <zaklawrencea@protonmail.com>
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.27.12 to 0.28.8. - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.27.12...v0.28.8) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [k8s.io/code-generator](https://github.com/kubernetes/code-generator) from 0.27.12 to 0.28.8. - [Commits](kubernetes/code-generator@v0.27.12...v0.28.8) --- updated-dependencies: - dependency-name: k8s.io/code-generator dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Use non-anonymous types for PCS status Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de> * Don't keep PCS CRD Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de> --------- Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
* remove e2es based on central ingress resources. Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com> * Remove source switchs e2es. Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com> * Adapt e2e tests to use segments. Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com> * Remove unused functions. Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com> * Update e2e howto. Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com> * Update e2e script. Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com> --------- Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com>
Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com>
Require unique non-empty hosts for ingress and routegroup specs. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
* Remove central ingress/routegroup logic; remove ingress source switch ttl logic. Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com> * Remove split HPA generation; rename StackSet Ingress function. Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com> * Update end-2-end test configuration. Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com> * Remove comment. Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com> --------- Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com>
linki
force-pushed
the
configmap-inline-another-try
branch
from
ef7d88d
to
e01e19e
Compare
linki
force-pushed
the
configuration-resources-simpler-tests
branch
from
eae7cce
to
2236de4
Compare
linki
force-pushed
the
configmap-inline-another-try
branch
from
433bc16
to
ef7d88d
Compare
|
Closing this as inactive. Let's follow up if we decide to support inline ConfigMaps. (This branch is supposed to be merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a first e2e test for Inline ConfigMaps developed in #593. It's based on the dedicated test suite created in #599.
It handles a very simple case where an inline ConfigMap with a single key-value pair of data is defined. It validates that a ConfigMap is created in the cluster with the expanded name (including the StackSet name and Stack version) as well as that it's owned by the Stack via ownerReferences.
TODOs
The rewrite portion hasn't been implemented yet, so the tests for that are skipped (see comment). I'd suggest to start by adding a test case here because the rewrite is probably the most delicate problem of this feature.
Please also see the previous PRs that are needed for this one: