Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump netty-codec-http from 4.1.58.Final to 4.1.59.Final #951

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps netty-codec-http from 4.1.58.Final to 4.1.59.Final. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Local Information Disclosure Vulnerability in Netty on Unix-Like systems due temporary files

Impact

When netty's multipart decoders are used local information disclosure can occur via the local system temporary directory if temporary storing uploads on the disk is enabled.

The CVSSv3.1 score of this vulnerability is calculated to be a 6.2/10

Vulnerability Details

On unix-like systems, the temporary directory is shared between all user. As such, writing to this directory using APIs that do not explicitly set the file/directory permissions can lead to information disclosure. Of note, this does not impact modern MacOS Operating Systems.

The method File.createTempFile on unix-like systems creates a random file, but, by default will create this file with the permissions -rw-r--r--. Thus, if sensitive information is written to this file, other local users can read this information.

This is the case in netty's AbstractDiskHttpData is vulnerable.

https://github.com/netty/netty/blob/e5951d46fc89db507ba7d2968d2ede26378f0b04/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java#L80-L101

AbstractDiskHttpData is used as a part of the DefaultHttpDataFactory class which is used by HttpPostRequestDecoder / HttpPostMultiPartRequestDecoder.

You may be affected by this vulnerability your project contains the following code patterns:

... (truncated)

Affected versions: < 4.1.59

Commits
  • 97d0448 [maven-release-plugin] prepare release netty-4.1.59.Final
  • c735357 Use Files.createTempFile(...) to ensure the file is created with proper permi...
  • 8f397e2 Update to latest os-maven-plugin (#11003)
  • c9a8d1d Fix test reports name
  • 73286d5 Publish test results after PR run (#11002)
  • d943d11 DecodeHexBenchmark is too branch-predictor friendly (#9942)
  • d0bcf44 Fix memory release failure when "maxNumElems == 1" of PoolSubpage (#10988)
  • 5460ae7 Bump ant from 1.9.15 to 1.10.9 (#10990)
  • 6ce1541 Revert HttpPostMultipartRequestDecoder and HttpPostStandardRequestDecoder to ...
  • ab8b8ae Introduce SslContextOption which can be used for "optional" features … (#10981)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [netty-codec-http](https://github.com/netty/netty) from 4.1.58.Final to 4.1.59.Final. **This update includes a security fix.**
- [Release notes](https://github.com/netty/netty/releases)
- [Commits](netty/netty@netty-4.1.58.Final...netty-4.1.59.Final)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies security Pull requests that address a security vulnerability labels Feb 8, 2021
@whiskeysierra
Copy link
Collaborator

👍

@whiskeysierra whiskeysierra merged commit d9453fa into main Feb 15, 2021
@dependabot-preview dependabot-preview bot deleted the dependabot/maven/io.netty-netty-codec-http-4.1.59.Final branch February 15, 2021 08:56
whiskeysierra added a commit that referenced this pull request Mar 7, 2021
* main:
  Add cookie value replacer function (#965)
  Bump spring-boot.version from 2.4.2 to 2.4.3 (#960)
  Bump jmh.version from 1.27 to 1.28 (#967)
  Bump jackson.version from 2.12.1 to 2.12.2 (#968)
  Bump spring-security-web from 5.4.4 to 5.4.5 (#959)
  Bump kotlin-stdlib from 1.4.30 to 1.4.31 (#966)
  Bump mockito.version from 3.7.7 to 3.8.0 (#962)
  Bump spring-framework-bom from 5.3.3 to 5.3.4 (#958)
  Bump reactor-netty from 1.0.3 to 1.0.4 (#957)
  [Security] Bump netty-codec-http from 4.1.58.Final to 4.1.59.Final (#951)
  Bump netty-codec-http in /logbook-netty (#952)
  Bump spring-security-web from 5.4.2 to 5.4.4 (#955)
  Bump dependency-check-maven from 6.1.0 to 6.1.1 (#956)
  Release/2.4.2 (#950)
whiskeysierra added a commit that referenced this pull request Mar 7, 2021
* main: (23 commits)
  Release 2.4.2 (#969)
  Add cookie value replacer function (#965)
  Bump spring-boot.version from 2.4.2 to 2.4.3 (#960)
  Bump jmh.version from 1.27 to 1.28 (#967)
  Bump jackson.version from 2.12.1 to 2.12.2 (#968)
  Bump spring-security-web from 5.4.4 to 5.4.5 (#959)
  Bump kotlin-stdlib from 1.4.30 to 1.4.31 (#966)
  Bump mockito.version from 3.7.7 to 3.8.0 (#962)
  Bump spring-framework-bom from 5.3.3 to 5.3.4 (#958)
  Bump reactor-netty from 1.0.3 to 1.0.4 (#957)
  [Security] Bump netty-codec-http from 4.1.58.Final to 4.1.59.Final (#951)
  Bump netty-codec-http in /logbook-netty (#952)
  Bump spring-security-web from 5.4.2 to 5.4.4 (#955)
  Bump dependency-check-maven from 6.1.0 to 6.1.1 (#956)
  Release/2.4.2 (#950)
  Bump dependency-check-maven from 6.0.5 to 6.1.0 (#939)
  Bump lombok from 1.18.16 to 1.18.18 (#940)
  Bump okhttp from 4.9.0 to 4.9.1 (#942)
  Bump kotlin-stdlib from 1.4.21-2 to 1.4.30 (#946)
  Bump junit.version from 5.7.0 to 5.7.1 (#947)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant