Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 9.3 by allowing disabling replication slots #18

Closed
jberkus opened this issue Sep 2, 2015 · 6 comments
Closed

support 9.3 by allowing disabling replication slots #18

jberkus opened this issue Sep 2, 2015 · 6 comments

Comments

@jberkus
Copy link
Contributor

jberkus commented Sep 2, 2015

... this should be possible.

@jberkus
Copy link
Contributor Author

jberkus commented Sep 4, 2015

Taken care of with PR #23

@CyberDem0n
Copy link
Member

Oh!
We can actually make this feature more smart and even make patroni compatible with postgresql < 9.3

  1. We should query major version in Postgresql.__init__
  2. If version < 9.4 forcefully set use_slots to False
  3. Get rid from pg_xlog_location_diff which exists only from 9.3 and use function utils.lsn_to_bytes (https://github.com/zalando/patroni/blob/master/helpers/utils.py#L45) instead.
  4. Profit

@CyberDem0n
Copy link
Member

Hmm, for postgres version < 9.3 formula is a little bit different...
Ok, will move this method into Postgresql and make it version-specific.

@CyberDem0n
Copy link
Member

2 wont work for slaves...
We have to know in advance that version < 9.4 in order to create proper recovery.conf but without starting cluster it's not really possible to determine version.

But at least everything else is doable.

#25

@jberkus
Copy link
Contributor Author

jberkus commented Sep 4, 2015

We don't care about supporting < 9.3 Here's why:

  1. Before 9.3, you couldn't remaster over streaming replication, making failover/failback and master change much more complicated.
  2. 9.3 was 2 years ago, and is the supported version in current stable Ubuntu, Debian, and Red Hat.

@CyberDem0n
Copy link
Member

Ok, dropped unneeded code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants