Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement possibility to configure Patroni via environment #211

Merged
merged 12 commits into from
Jun 14, 2016
Merged

Implement possibility to configure Patroni via environment #211

merged 12 commits into from
Jun 14, 2016

Conversation

CyberDem0n
Copy link
Member

No description provided.

alexeyklyukin
alexeyklyukin reviewed Jun 8, 2016
View reviewed changes
docs/ENVIRONMENT.rst
Environment Configuration Settings
==================================

Some of configuration parameters defined in the configuration file is possible to override via Environment variables
Copy link
Contributor

@alexeyklyukin alexeyklyukin Jun 8, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the description to the following one:

It is possible to override some of the configuration parameters defined in the Patroni configuration file using the system environment variables. This document lists all environment variables handled by Patroni. The values set via those variables always take precedence over the ones set in the Patroni configuration file or via the PATRONI_CONFIGURATION environment variable.

@alexeyklyukin
Copy link
Contributor

+1

Make it possible to work without config.yml
49efb37 
Most of the basic configuration could be done via ENV
@feikesteenbergen
Copy link
Contributor

👍

Alexander Kukushkin added 2 commits June 10, 2016 12:30
Merge branch 'feature/dynamic-configuration' of github.com:zalando/pa…
19037da 
…troni into feature/environment-configuration
Bugfixes
9ecff0f 
* GET /config was returning latesy "correct" version of dynamic
  configuration.
* PATCH /config was breaking when trying to patch not dict with dict
@alexeyklyukin
Copy link
Contributor

+1

@coveralls
Copy link

coveralls commented Jun 10, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 99.876% when pulling 9ecff0f on feature/environment-configuration into 95db725 on feature/dynamic-configuration.

@CyberDem0n CyberDem0n merged commit f2980b1 into feature/dynamic-configuration Jun 14, 2016
@CyberDem0n CyberDem0n deleted the feature/environment-configuration branch June 14, 2016 08:10
@CyberDem0n CyberDem0n mentioned this pull request Aug 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CyberDem0n @alexeyklyukin @feikesteenbergen @coveralls @lasomethingsomething