Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

error in version check of maven in build.sh #59

Closed
holgerjakobs opened this issue Nov 21, 2015 · 3 comments
Closed

error in version check of maven in build.sh #59

holgerjakobs opened this issue Nov 21, 2015 · 3 comments

Comments

@holgerjakobs
Copy link

The command gathering the Maven version in build.sh should read
MAVEN_VERSION=$(mvn --version | grep -o '3.' | head -n 1)

The original (with head first and then grep) writes "3.\n3." into the variable which is different from "3."

@kmoppel
Copy link
Contributor

kmoppel commented Nov 25, 2015

Hi, thanks for the report!
But for me (Ubuntu+Bash 4.3.11) actually the output ("3.") seems correct...what kind of system are you using? Maybe we can make it more universal indeed.

@kmoppel
Copy link
Contributor

kmoppel commented Mar 8, 2016

@Pelleplutt Hi. Couldn't grasp the context of your comment:) Is there something that's not working for you?

@Pelleplutt
Copy link

@kmoppel my message was related to the issue reported by @holgerjakobs about version numbering. All is fine for me. But reading this thread less hastily now I see that it was premature. Please ignore.

slitsche added a commit that referenced this issue Oct 7, 2016
Fixed incorrect maven version detection
Solves #59
@slitsche slitsche closed this as completed Oct 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants