Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review request for Split #8

Closed
GoogleCodeExporter opened this issue Dec 25, 2015 · 7 comments
Closed

Code review request for Split #8

GoogleCodeExporter opened this issue Dec 25, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

Purpose of code changes on this branch:

When I added the Batch operator, I thought I could implement it in terms 
of a generalized Split operator. I was wrong, but the damage was already 
done and I had implemented and factored out all the work to implement a 
Split operator for any enumerable source. However, I have doubts about its 
general usefulness and is the reason why I am putting it in a branch.

When reviewing my code changes, please focus on:

I would appreciate it if you could review and comment on "utility" and 
general application of this operator. If you find that it makes good sense 
then I can merge it back into the turnk. Otherwise the branch can just 
serve as an archive.

After the review, I'll merge this branch into:
/trunk


Original issue reported on code.google.com by azizatif on 17 Feb 2009 at 6:17

@GoogleCodeExporter
Copy link
Author

Original comment by azizatif on 19 Feb 2009 at 1:00

  • Changed title: Code review request for Split

@GoogleCodeExporter
Copy link
Author

Interesingly, similar Split implementation below except it is 
specialized/optimized 
for strings:

http://stackoverflow.com/questions/298830/split-string-containing-command-line-
parameters-into-string-in-c/298990#298990

Original comment by azizatif on 14 Apr 2009 at 11:11

@GoogleCodeExporter
Copy link
Author

Set review issue status to: Accepted

Original comment by jojo.rudolph@googlemail.com on 22 Apr 2010 at 3:08

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Ok, I have found a pretty cool solution, it needs a little polishing but should 
be 
available tomorrow after I had a little sleep ;-)

Original comment by jojo.rudolph@googlemail.com on 22 Apr 2010 at 11:21

@GoogleCodeExporter
Copy link
Author

Bump!

Would be good if this can be reviewed prior to migrating[1] to Hg in the 
interest of having fewer open branches to carry forward.

[1] https://groups.google.com/forum/?fromgroups#!topic/morelinq-dev/IHE7LMH_eBU

Original comment by azizatif on 24 May 2012 at 5:14

@GoogleCodeExporter
Copy link
Author

Original comment by azizatif on 25 May 2012 at 4:40

  • Changed state: Duplicate

@GoogleCodeExporter
Copy link
Author

Original comment by azizatif on 25 May 2012 at 4:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant