Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8 could be run on non-existing file and still give full grade! #2

Open
zalsaeed opened this issue Apr 4, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@zalsaeed
Copy link
Owner

zalsaeed commented Apr 4, 2023

when running a test using flake8, such as

ExecutableTask(16, "Check Coding Style for type annotations using Flake8 (we check for ANN001, ANN201, "
                               "ANN202, ANN203, ANN204, ANN205, and ANN206). Each missing annotation worth 1 point!",
                           possible_points=10,
                           command=PythonCommand(coding_style.check_for_type_hints, args=[student, "point.py"])),

flake8 will return total points (according to the possible grade) even if the file doesn't exist. This is a logical grading bug.

@zalsaeed zalsaeed added the bug Something isn't working label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant