Helm chart checks for wrong Elasticsearch credentials

[orbatschow]

Is this a request for help?:
No

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Bug

Version of Helm and Kubernetes:
v2

What happened:
Zammad is unable to verify against the Elasticsearch API, because the user and password are not set properly.

What you expected to happen:
The helm template should not verify against .Values.elasticsearch.pass, but Values.envConfig.elasticsearch.pass and user respectively.

How to reproduce it (as minimally and precisely as possible):

1. Deploy chart version 2.6.1 with an external Elasticsearch cluster configured
2. Check the "elasticsearch-init" container:

I, [2020-10-05T15:00:18.539348 #6-47041080449380]  INFO -- : Setting.set('models_searchable', ["Organization", "KnowledgeBase::Answer::Translation", "User", "Chat::Session", "Ticket"])
I, [2020-10-05T15:00:19.430781 #6-47041080449380]  INFO -- : Setting.set('es_url', "https://elasticsearch-es-master.elk.svc.cluster.local:9200")
rake aborted!
Unable to process GET request to elasticsearch URL 'https://elasticsearch-es-master.elk.svc.cluster.local:9200'. Check the response and payload for detailed information: 

Response:
#<UserAgent::Result:0x00005625c2492878 @success=false, @body="{\"error\":{\"root_cause\":[{\"type\":\"security_exception\",\"reason\":\"missing authentication credentials for REST request [/]\",\"header\":{\"WWW-Authenticate\":[\"Bearer realm=\\\"security\\\"\",\"ApiKey\",\"Basic realm=\\\"security\\\" charset=\\\"UTF-8\\\"\"]}}],\"type\":\"security_exception\",\"reason\":\"missing authentication credentials for REST request [/]\",\"header\":{\"WWW-Authenticate\":[\"Bearer realm=\\\"security\\\"\",\"ApiKey\",\"Basic realm=\\\"security\\\" charset=\\\"UTF-8\\\"\"]}},\"status\":401}", @data=nil, @code="401", @content_type=nil, @error="Client Error: #<Net::HTTPUnauthorized 401 Unauthorized readbody=true>!">

The Elasticsearch configmap-init.yaml does not contain the relevant section for setting the user and the password, because the evaluation always fails. Either a default has to be added or (IMHO the better way) the check should default to Values.envConfig.elasticsearch.user

apiVersion: v1
kind: ConfigMap
  name: zammad-cluster-dev-01-init
  namespace: default
data:
  elasticsearch-init: >-
    #!/bin/bash

    set -e

    bundle exec rails r 'Setting.set("es_url",
    "https://elasticsearch-es-master.elk.svc.cluster.local:9200")'

    bundle exec rake searchindex:rebuild


    echo "elasticsearch init complete :)"
...

[monotek]

will be fixed with: #64

[orbatschow]

I created a PR before I saw yours. The default credentials should contain a valid string, as I think Helm evaluates an empty string to false.