Enable Lint/UselessAssignment cop.

.rubocop_todo.rspec.yml

@@ -6,10 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 43
-Lint/UselessAssignment:
-  Enabled: false
-
 # # Offense count: 17 (Competes with same override in .rubocop_todo.yml)
 # Metrics/AbcSize:
 #   Max: 24

app/controllers/application_channel_controller.rb

@@ -41,7 +41,7 @@ def channel
   end
 
   def channel_params
-    params = params.permit!.to_s
+    params.permit!.to_s
   end
 
 end

app/controllers/application_controller/renders_models.rb

@@ -101,22 +101,11 @@ def model_show_render_item(generic_object)
   end
 
   def model_index_render(object, params)
-    offset = 0
-    per_page = 500
-    if params[:page] && params[:per_page]
-      offset = (params[:page].to_i - 1) * params[:per_page].to_i
-      limit = params[:per_page].to_i
-    end
-
-    if per_page > 500
-      per_page = 500
-    end
+    page = (params[:page] || 1).to_i
+    per_page = (params[:per_page] || 500).to_i
+    offset = (page - 1) * per_page
 
-    generic_objects = if offset.positive?
-                        object.limit(params[:per_page]).order(id: :asc).offset(offset).limit(limit)
-                      else
-                        object.all.order(id: :asc).offset(offset).limit(limit)
-                      end
+    generic_objects = object.order(id: :asc).offset(offset).limit(per_page)
 
     if response_expand?
       list = []

app/controllers/channels_email_controller.rb

@@ -171,7 +171,7 @@ def verify
         channel_id: channel.id,
       )
     else
-      address = EmailAddress.create(
+      EmailAddress.create(
         realname:   params[:meta][:realname],
         email:      email,
         active:     true,

app/controllers/concerns/creates_ticket_articles.rb

@@ -96,7 +96,7 @@ def article_create(ticket, params)
         begin
           base64_data = attachment[:data].gsub(/[\r\n]/, '')
           attachment_data = Base64.strict_decode64(base64_data)
-        rescue ArgumentError => e
+        rescue ArgumentError
           raise Exceptions::UnprocessableEntity, "Invalid base64 for attachment with index '#{index}'"
         end
 

app/controllers/import_otrs_controller.rb

@@ -123,7 +123,7 @@ def import_start
   end
 
   def import_check
-    statistic = Import::OTRS::Requester.list
+    Import::OTRS::Requester.list
     issues = []
 
     # check count of dynamic fields

app/controllers/integration/check_mk_controller.rb

@@ -55,7 +55,7 @@ def update
         ticket = Ticket.find_by(id: ticket_id)
         next if !ticket
 
-        article = Ticket::Article.create!(
+        Ticket::Article.create!(
           ticket_id: ticket_id,
           type_id:   Ticket::Article::Type.find_by(name: 'web').id,
           sender_id: Ticket::Article::Sender.find_by(name: 'Customer').id,
@@ -81,7 +81,6 @@ def update
         }
         return
       end
-      state = Ticket::State.lookup(id: auto_close_state_id)
       ticket_ids_found.each do |ticket_id|
         ticket = Ticket.find_by(id: ticket_id)
         next if !ticket
@@ -107,7 +106,7 @@ def update
         },
       }
     )
-    article = Ticket::Article.create!(
+    Ticket::Article.create!(
       ticket_id: ticket.id,
       type_id:   Ticket::Article::Type.find_by(name: 'web').id,
       sender_id: Ticket::Article::Sender.find_by(name: 'Customer').id,

app/controllers/knowledge_base/answer/attachments_controller.rb

@@ -9,7 +9,7 @@ class KnowledgeBase::Answer::AttachmentsController < ApplicationController
   def create
     file = params[:file]
 
-    store = Store.add(
+    Store.add(
       object:      @answer.class.name,
       o_id:        @answer.id,
       data:        file.read,

app/controllers/long_polling_controller.rb

@@ -89,7 +89,7 @@ def message_receive
           return
         end
       end
-    rescue => e
+    rescue
       raise Exceptions::UnprocessableEntity, 'Invalid client_id in receive loop!'
     end
   end

app/controllers/slas_controller.rb

@@ -52,7 +52,6 @@ def index
 
       # calendars
       assets = {}
-      calendar_ids = []
       Calendar.all.each do |calendar|
         assets = calendar.assets(assets)
       end

app/controllers/ticket_overviews_controller.rb

@@ -10,7 +10,6 @@ def show
       index_and_lists = Ticket::Overviews.index(current_user)
       indexes = []
       index_and_lists.each do |index|
-        assets = {}
         overview = Overview.lookup(id: index[:overview][:id])
         meta = {
           name:  overview.name,

app/controllers/time_accountings_controller.rb

@@ -49,7 +49,6 @@ def by_ticket
       end
       if !agents[local_time_unit[:agent_id]]
         agent_user = User.lookup(id: local_time_unit[:agent_id])
-        agent = '-'
         if agent_user
           agents[local_time_unit[:agent_id]] = agent_user.fullname
         end

app/controllers/users_controller.rb

@@ -380,7 +380,7 @@ def search
 
     query = params[:query]
     if query.respond_to?(:permit!)
-      query = query.permit!.to_h
+      query.permit!.to_h
     end
 
     query = params[:query] || params[:term]
@@ -543,7 +543,7 @@ def email_verify_send
     #  return
     #end
 
-    token = Token.create(action: 'Signup', user_id: user.id)
+    Token.create(action: 'Signup', user_id: user.id)
 
     result = User.signup_new_token(user)
     if result && result[:token]

app/jobs/ticket_article_communicate_email_job.rb

@@ -9,7 +9,6 @@ def perform(article_id)
 
     # build subject
     ticket = Ticket.lookup(id: record.ticket_id)
-    article_count = Ticket::Article.where(ticket_id: ticket.id).count
 
     subject_prefix_mode = record.preferences[:subtype]
 

app/models/application_model/can_lookup.rb

@@ -25,8 +25,7 @@ def lookup(**attr)
       attr.transform_keys!(&:to_sym).slice!(*lookup_keys)
       raise ArgumentError, "Valid lookup attribute required (#{lookup_keys.join(', ')})" if attr.empty?
 
-      record   = cache_get(attr.values.first)
-      record ||= find_and_save_to_cache_by(attr)
+      cache_get(attr.values.first) || find_and_save_to_cache_by(attr)
     end
 
 =begin

app/models/application_model/can_lookup_search_index_attributes.rb

@@ -22,8 +22,7 @@ def search_index_attribute_lookup
       next if !value
 
       # get attribute name
-      attribute_name_with_id = key.to_s
-      attribute_name         = key.to_s
+      attribute_name = key.to_s
       next if attribute_name[-3, 3] != '_id'
 
       attribute_name = attribute_name[ 0, attribute_name.length - 3 ]

app/models/application_model/has_attachments.rb

@@ -86,6 +86,5 @@ def attachments_buffer_check
         created_by_id: created_by_id,
       )
     end
-    attachments_buffer = nil
   end
 end

app/models/channel/driver/sms/twilio.rb

@@ -40,7 +40,7 @@ def process(_options, attr, channel)
     # find sender
     user = User.where(mobile: attr[:From]).order(:updated_at).first
     if !user
-      from_comment, preferences = Cti::CallerId.get_comment_preferences(attr[:From], 'from')
+      _from_comment, preferences = Cti::CallerId.get_comment_preferences(attr[:From], 'from')
       if preferences && preferences['from'] && preferences['from'][0]
         if preferences['from'][0]['level'] == 'known' && preferences['from'][0]['object'] == 'User'
           user = User.find_by(id: preferences['from'][0]['o_id'])

app/models/channel/email_parser.rb

@@ -202,9 +202,6 @@ def _process(channel, msg)
         # save changes set by x-zammad-ticket-followup-* headers
         ticket.save! if ticket.has_changes_to_save?
 
-        state      = Ticket::State.find(ticket.state_id)
-        state_type = Ticket::StateType.find(state.state_type_id)
-
         # set ticket to open again or keep create state
         if !mail['x-zammad-ticket-followup-state'.to_sym] && !mail['x-zammad-ticket-followup-state_id'.to_sym]
           new_state = Ticket::State.find_by(default_create: true)
@@ -480,7 +477,7 @@ def self.process_unprocessable_mails(params = {})
     path = Rails.root.join('tmp', 'unprocessable_mail')
     files = []
     Dir.glob("#{path}/*.eml") do |entry|
-      ticket, article, user, mail = Channel::EmailParser.new.process(params, IO.binread(entry))
+      ticket, _article, _user, _mail = Channel::EmailParser.new.process(params, IO.binread(entry))
       next if ticket.blank?
 
       files.push entry
@@ -608,15 +605,13 @@ def get_attachments(file, attachments, mail)
     file.header.fields.each do |field|
 
       # full line, encode, ready for storage
-
       value = field.to_utf8
       if value.blank?
         value = field.raw_value
       end
       headers_store[field.name.to_s] = value
-    rescue => e
+    rescue
       headers_store[field.name.to_s] = field.raw_value
-
     end
 
     # cleanup content id, <> will be added automatically later

app/models/channel/filter/monitoring_base.rb

@@ -80,9 +80,6 @@ def self.run(_channel, mail)
                         end
     end
 
-    # check if ticket with host is open
-    customer = User.lookup(id: session_user_id)
-
     # follow up detection by meta data
     open_states = Ticket::State.by_category(:open)
     ticket_ids = Ticket.where(state: open_states).order(created_at: :desc).limit(5000).pluck(:id)

app/models/concerns/checks_condition_validation.rb

@@ -26,7 +26,7 @@ def validate_condition
       value:    1,
     }
 
-    ticket_count, tickets = Ticket.selectors(validate_condition, limit: 1, current_user: User.find(1))
+    ticket_count, _tickets = Ticket.selectors(validate_condition, limit: 1, current_user: User.find(1))
     return true if ticket_count.present?
 
     raise Exceptions::UnprocessableEntity, 'Invalid ticket selector conditions'

app/models/concerns/has_groups.rb

@@ -248,7 +248,7 @@ def flush_group_access_buffer
     return if group_access_buffer.nil?
 
     yield
-    group_access_buffer = nil
+    self.group_access_buffer = nil
     cache_delete
   end
 

app/models/job.rb

@@ -135,7 +135,7 @@ def in_timeplan?(time = Time.zone.now)
   end
 
   def matching_count
-    ticket_count, tickets = Ticket.selectors(condition, limit: 1)
+    ticket_count, _tickets = Ticket.selectors(condition, limit: 1)
     ticket_count || 0
   end
 

app/models/knowledge_base/answer.rb

@@ -49,7 +49,7 @@ def assets(data = {})
     end
 
     data = ApplicationModel::CanAssets.reduce(siblings, data)
-    data = ApplicationModel::CanAssets.reduce(translations, data)
+    ApplicationModel::CanAssets.reduce(translations, data)
   end
 
   attachments_cleanup!

app/models/knowledge_base/category.rb

@@ -50,7 +50,7 @@ def assets(data = {})
     data = ApplicationModel::CanAssets.reduce(translations, data)
 
     # include parent category or KB for root to have full path
-    data = (parent || knowledge_base).assets(data)
+    (parent || knowledge_base).assets(data)
   end
 
   def self_parent?(candidate)

app/models/object_manager/attribute.rb

@@ -54,7 +54,6 @@ def self.list_full
     result = ObjectManager::Attribute.all.order('position ASC, name ASC')
     references = ObjectManager::Attribute.attribute_to_references_hash
     attributes = []
-    assets = {}
     result.each do |item|
       attribute = item.attributes
       attribute[:object] = ObjectLookup.by_id(item.object_lookup_id)
@@ -908,7 +907,7 @@ def check_name
     # fixes issue #2236 - Naming an attribute "attribute" causes ActiveRecord failure
     begin
       ObjectLookup.by_id(object_lookup_id).constantize.instance_method_already_implemented? name
-    rescue  ActiveRecord::DangerousAttributeError => e
+    rescue  ActiveRecord::DangerousAttributeError
       raise "#{name} is a reserved word, please choose a different one"
     end
 

app/models/object_manager/attribute/validation/required.rb

@@ -22,7 +22,7 @@ def system_user?
   end
 
   def user_id
-    user_id ||= UserInfo.current_user_id
+    @user_id ||= UserInfo.current_user_id
   end
 
   def user

app/models/observer/sla/ticket_rebuild_escalation.rb

@@ -25,7 +25,6 @@ def _check(record)
 
     # check if condition has changed
     changed = false
-    fields_to_check = nil
     fields_to_check = if record.class == Sla
                         %w[condition calendar_id first_response_time update_time solution_time]
                       else

app/models/observer/transaction.rb

@@ -217,7 +217,6 @@ def before_update(record)
     # do not send anything if nothing has changed
     return true if real_changes.blank?
 
-    changed_by_id = nil
     changed_by_id = if record.respond_to?('updated_by_id')
                       record.updated_by_id
                     else

app/models/package.rb

@@ -505,8 +505,6 @@ def self.migrate(package, direction = 'normal')
 
       return true if !File.exist?(location)
 
-      migrations_done = Package::Migration.where(name: package.underscore)
-
       # get existing migrations
       migrations_existing = []
       Dir.foreach(location) do |entry|

app/models/store.rb

@@ -287,7 +287,6 @@ def image_resize(content, width)
     local_sha = Digest::SHA256.hexdigest(content)
 
     cache_key = "image-resize-#{local_sha}_#{width}"
-    all = nil
     image = Cache.get(cache_key)
     return image if image
 

app/models/store/provider/file.rb

@@ -108,7 +108,7 @@ def self.get_location(sha)
     if !File.exist?(location)
       FileUtils.mkdir_p(location)
     end
-    full_path = location += file
+    full_path = location + file
     full_path.gsub('//', '/')
   end
 

app/models/text_module.rb

@@ -100,7 +100,7 @@ def self.push(locale)
 
     # set new translator_key if given
     if result.data['translator_key']
-      translator_key = Setting.set('translator_key', result.data['translator_key'])
+      Setting.set('translator_key', result.data['translator_key'])
     end
 
     true