Follow up 34ec90b - Fixes #4243 - Add migration to fix existing roles…

… without ticket.agent permission but group relations.

db/migrate/20220922090123_issue4243_permission_fix.rb

@@ -0,0 +1,14 @@
+# Copyright (C) 2012-2022 Zammad Foundation, https://zammad-foundation.org/
+
+class Issue4243PermissionFix < ActiveRecord::Migration[6.1]
+  def change
+    # return if it's a new setup
+    return if !Setting.exists?(name: 'system_init_done')
+
+    Role.find_each do |role|
+      next if role.groups.blank?
+
+      role.permissions |= Permission.where(name: 'ticket.agent')
+    end
+  end
+end

spec/db/migrate/issue_4243_permission_fix_spec.rb

@@ -0,0 +1,21 @@
+# Copyright (C) 2012-2022 Zammad Foundation, https://zammad-foundation.org/
+
+require 'rails_helper'
+
+RSpec.describe Issue4243PermissionFix, type: :db_migration do
+  let!(:test_role) do
+    role = create(:role)
+    role.group_names_access_map = {
+      Group.first.name => 'full',
+    }
+    role
+  end
+
+  before do
+    migrate
+  end
+
+  it 'does add the permission if groups are present but ticket.agent permission is not set' do
+    expect(test_role.reload.permissions).to include(Permission.find_by(name: 'ticket.agent'))
+  end
+end