Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger email notification UI defective on removal of recipient #2516

Closed
sstidl opened this issue Mar 18, 2019 · 6 comments
Closed

trigger email notification UI defective on removal of recipient #2516

sstidl opened this issue Mar 18, 2019 · 6 comments

Comments

@sstidl
Copy link

sstidl commented Mar 18, 2019

Infos:

  • Used Zammad version: 2.9.x docker as of 18th of march 2019
  • Installation method (source, package, ..): docker REPO=zammad/zammad-docker-compose
  • Operating system: debian 9
  • Database + version: docker default
  • Elasticsearch version: docker default
  • Browser + version: docker default

Expected behavior:

  • in Trigger Edit mode, Action "Email" works like expected: removing someone to receive an email just removes this person or group

Actual behavior:

  • when removing something from the upper left list, the whole UI vanishes, leaving the UI in a defective state.

Steps to reproduce the behavior:

  • use /#manage/trigger UI to create a new trigger

  • use in actions UI the action "Email" notification

  • use owner from the list right to add it to the list of persons to be notified

  • fill out everything needed to save the notification

  • save it and reopen it
    image

  • add "all agents" to the list
    image

  • and remove it
    => UI is damaged now

image

@sstidl sstidl changed the title trigger UI trigger email notification UI defective on removal of recipient Mar 18, 2019
@MrGeneration
Copy link
Member

This also affects condition on triggerss:
image

Removing all actions works in:

  • Scheduler
  • Trigger

Removing all conditions works in:

  • Trigger
  • Report Profiles (note this throws error "{"error":"no selectors given"}" and will not apply this even though it does let you submit this change)
  • time accounting
  • SLAs (note this throws error "{"error":"no selectors given"}" and will not apply this even though it does let you submit this change)
  • Postmaster filters
  • auto assignment

Please note that every where I could submit, the changes did not take effect. So this is mostly a UI issue, after reloading Zammad they last option you removed will be there again.

@sstidl
Copy link
Author

sstidl commented Jun 7, 2019

Is this really not fixed in 3.0?

@martini martini self-assigned this Jun 7, 2019
@martini martini added this to the 2.9.1 milestone Jun 7, 2019
@MrGeneration
Copy link
Member

No it's not.

@MrGeneration MrGeneration modified the milestones: 2.9.1, 3.0.1 Jun 7, 2019
@martini
Copy link
Collaborator

martini commented Jun 7, 2019

Is this really not fixed in 3.0?

Just saw it. It's in CI now... it's coming...

@martini martini modified the milestones: 3.0.1, 2.9.1 Jun 7, 2019
zammad-sync pushed a commit that referenced this issue Jun 7, 2019
zammad-sync pushed a commit that referenced this issue Jun 7, 2019
zammad-sync pushed a commit that referenced this issue Jun 7, 2019
@martini
Copy link
Collaborator

martini commented Jun 7, 2019

It's now fixed for Zammad 3.0 and 2.9. 🥂

@martini martini closed this as completed Jun 7, 2019
@sstidl
Copy link
Author

sstidl commented Jun 8, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants