Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing last condition or action breaks dialogues #2764

Closed
MrGeneration opened this issue Oct 4, 2019 · 1 comment
Closed

Removing last condition or action breaks dialogues #2764

MrGeneration opened this issue Oct 4, 2019 · 1 comment

Comments

@MrGeneration
Copy link
Member

MrGeneration commented Oct 4, 2019

Infos:

  • Used Zammad version: 3.1
  • Installation method (source, package, ..): any
  • Operating system: any
  • Database + version: any
  • Elasticsearch version: any
  • Browser + version: Tested and verified on Firefox and Chrome (latest)

This seems to be -at least partly- a regression of #2516

This issue was found by the Community-Member: https://community.zammad.org/u/bebosudo

Expected behavior:

  • not being able to remove the last action or condition on modal dialogues.

Actual behavior:

  • On most of the dialogues you can remove the last action and/or condition in modal dialogues. This draws the UI useless (if you save that change), because you'll never be able to re-add conditions or actions.

affected interfaces:

This list might be incomplete, but I successfully tested this at least partly (condition or action) on:

  • Trigger
  • Scheduler
  • SLA
  • Reporting-Profiles
  • Time Accounting
  • Overviews
  • Postmaster FIlters

Possibly also affects integrations like LDAP, but this is untested.

Screencast with example:

deleting-action-possible

Steps to reproduce the behavior:

  • go to any modal dialogue that contains conditions and/or actions
  • try to remove all conditions or actions

Yes I'm sure this is a bug and no feature request or a general question.

@bebosudo
Copy link

bebosudo commented Oct 4, 2019

May I suggest a UI improvement?
I think it would be "easier" to use a delete/trash icon on every row of condition/action (as it is now) and a single add with plus icon below.
What's the meaning of having a plus on the first row? Is it any different from the second or third "add" button?

bolah2009 added a commit to bolah2009/zammad that referenced this issue Feb 14, 2020
bolah2009 added a commit to bolah2009/zammad that referenced this issue Feb 16, 2020
This commit fixes the bug in zammad#2764 about the Postmaster filter, a condition is added to the click event handler on the remove button. The condition checks if the button is disabled, if it is not disabled the element is removed, otherwise it does nothing.
@thorsteneckel thorsteneckel added this to the 3.3.0 milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants