Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Rhbz1124630 - remove RESTEasy dependency from client #37

Merged
merged 9 commits into from Dec 10, 2014

Conversation

huangp
Copy link
Collaborator

@huangp huangp commented Nov 19, 2014

by switching to jersey as JAX-RS implementation, in fedora we could save users 200MB download.

Depend on zanata/zanata-parent#36 (now merged)

Not really depend on this but it's nice to have (especially in preparation for Fedora packaging) zanata/zanata-api#22

@huangp huangp force-pushed the jersey-boys branch 2 times, most recently from c8a0966 to 5191642 Compare November 19, 2014 06:18
<plugin>
<groupId>com.ning.maven.plugins</groupId>
<artifactId>maven-duplicate-finder-plugin</artifactId>
<version>1.0.7</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we inherit the version from elsewhere?

@seanf
Copy link
Contributor

seanf commented Nov 28, 2014

A number of files are missing their last newlines.

@huangp
Copy link
Collaborator Author

huangp commented Dec 1, 2014

@seanf last 3 commits should have fixed everything from your comments

@definite
Copy link
Member

definite commented Dec 4, 2014

Tested with commit ffcc07c

Push with tar-1.26
== ][ERROR] Operation failed: Invalid syntax for the expression '%5Ba-zA-Z0-9%5D+(%5Ba-zA-Z0-9_%5C-,{.}%5D*%5Ba-zA-Z0-9%5D+)%3F' associated with the name 'id'

To retry from the last document, please set the following option(s):

    --from-doc "tar"

.
[ERROR] Execution failed:
java.lang.RuntimeException: Invalid syntax for the expression '%5Ba-zA-Z0-9%5D+(%5Ba-zA-Z0-9_%5C-,{.}%5D_%5Ba-zA-Z0-9%5D+)%3F' associated with the name 'id'
at org.zanata.client.commands.push.PushCommand.pushCurrentModule(PushCommand.java:428)
at org.zanata.client.commands.push.PushCommand.run(PushCommand.java:199)
at org.zanata.client.commands.ConfigurableCommand.runWithActions(ConfigurableCommand.java:106)
at org.zanata.client.commands.ArgsUtil.runCommand(ArgsUtil.java:48)
at org.zanata.client.ZanataClient.processArgs(ZanataClient.java:170)
at org.zanata.client.ZanataClient.main(ZanataClient.java:95)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:297)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalArgumentException: Invalid syntax for the expression '%5Ba-zA-Z0-9%5D+(%5Ba-zA-Z0-9_%5C-,{.}%5D_%5Ba-zA-Z0-9%5D+)%3F' associated with the name 'id'
at com.sun.jersey.api.uri.UriTemplateParser.parseName(UriTemplateParser.java:390)
at com.sun.jersey.api.uri.UriTemplateParser.parse(UriTemplateParser.java:282)
at com.sun.jersey.api.uri.UriTemplateParser.(UriTemplateParser.java:154)
at com.sun.jersey.api.uri.UriTemplate.createURIComponent(UriTemplate.java:799)
at com.sun.jersey.api.uri.UriTemplate.createURIWithStringValues(UriTemplate.java:769)
at com.sun.jersey.api.uri.UriTemplate.createURIWithStringValues(UriTemplate.java:720)
at com.sun.jersey.api.uri.UriTemplate.createURI(UriTemplate.java:663)
at com.sun.jersey.api.uri.UriBuilderImpl.build(UriBuilderImpl.java:661)
at com.sun.jersey.api.uri.UriBuilderImpl.build(UriBuilderImpl.java:641)
at org.zanata.rest.client.ClientUtil.resolvePath(ClientUtil.java:69)
at org.zanata.rest.client.AsyncProcessClient.startSourceDocCreationOrUpdate(AsyncProcessClient.java:68)
at org.zanata.client.commands.push.PushCommand.pushSrcDocToServer(PushCommand.java:499)
at org.zanata.client.commands.push.PushCommand.pushCurrentModule(PushCommand.java:384)
... 11 more
Caused by: java.util.regex.PatternSyntaxException: Illegal repetition near index 34
%5Ba-zA-Z0-9%5D+(%5Ba-zA-Z0-9
%5C-,{.}%5D*%5Ba-zA-Z0-9%5D+)%3F
^
at java.util.regex.Pattern.error(Pattern.java:1924)
at java.util.regex.Pattern.closure(Pattern.java:3104)
at java.util.regex.Pattern.sequence(Pattern.java:2101)
at java.util.regex.Pattern.expr(Pattern.java:1964)
at java.util.regex.Pattern.group0(Pattern.java:2854)
at java.util.regex.Pattern.sequence(Pattern.java:2018)
at java.util.regex.Pattern.expr(Pattern.java:1964)
at java.util.regex.Pattern.compile(Pattern.java:1665)
at java.util.regex.Pattern.(Pattern.java:1337)
at java.util.regex.Pattern.compile(Pattern.java:1022)
at com.sun.jersey.api.uri.UriTemplateParser.parseName(UriTemplateParser.java:366)
... 23 more

@definite definite removed the On QA label Dec 4, 2014
- jersey can not handle path template with regex in path param
- extra url prefix (i.e. rest) will get appended twice using previous method
@definite
Copy link
Member

definite commented Dec 8, 2014

👍

huangp pushed a commit that referenced this pull request Dec 10, 2014
Rhbz1124630 - remove RESTEasy dependency from client
@huangp huangp merged commit 8fee4de into integration/master Dec 10, 2014
@huangp huangp deleted the jersey-boys branch December 10, 2014 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants