fix: add serialVersionUID for serializable class (#483)

zanata · Aug 17, 2017 · 1ff034f · 1ff034f
1 parent 3d788f8
commit 1ff034f
Show file tree

Hide file tree

Showing 213 changed files with 344 additions and 16 deletions.
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -290,7 +290,7 @@ timestamps {
                         //[parserName: 'appserver log messages'], // 119 warnings
                         //[parserName: 'browser warnings'],       // 0 warnings
                 ],
-                unstableTotalAll: '753',
+                unstableTotalAll: '500',
                 unstableTotalHigh: '0',
           ])
           // TODO check integration test warnings (EAP and WildFly)

diff --git a/server/services/src/main/java/org/zanata/action/CacheAction.java b/server/services/src/main/java/org/zanata/action/CacheAction.java
@@ -49,6 +49,7 @@
 public class CacheAction implements Serializable {
     private static final org.slf4j.Logger log =
             org.slf4j.LoggerFactory.getLogger(CacheAction.class);
+    private static final long serialVersionUID = -4179920199273998215L;
     @SuppressFBWarnings("SE_BAD_FIELD")
     @Inject
     @Zanata

diff --git a/server/services/src/main/java/org/zanata/action/ContactAdminAction.java b/server/services/src/main/java/org/zanata/action/ContactAdminAction.java
@@ -53,6 +53,7 @@
 public class ContactAdminAction implements Serializable {
     private static final org.slf4j.Logger log =
             org.slf4j.LoggerFactory.getLogger(ContactAdminAction.class);
+    private static final long serialVersionUID = -5891506955608084664L;
 
     @Inject
     @Authenticated

diff --git a/server/services/src/main/java/org/zanata/action/ContactLanguageTeamMembersAction.java b/server/services/src/main/java/org/zanata/action/ContactLanguageTeamMembersAction.java
@@ -49,6 +49,7 @@
 public class ContactLanguageTeamMembersAction implements Serializable {
     private static final org.slf4j.Logger log = org.slf4j.LoggerFactory
             .getLogger(ContactLanguageTeamMembersAction.class);
+    private static final long serialVersionUID = -5039341516353267288L;
 
     @Inject
     @Authenticated

diff --git a/server/services/src/main/java/org/zanata/action/DashboardAction.java b/server/services/src/main/java/org/zanata/action/DashboardAction.java
@@ -192,6 +192,7 @@ public boolean canCreateGroup() {
     public static class ProjectFilter extends AbstractListFilter<HProject>
             implements Serializable {
 
+        private static final long serialVersionUID = -2473428615946542483L;
         @Inject
         @Authenticated
         private HAccount authenticatedAccount;
@@ -218,6 +219,7 @@ protected long fetchTotalRecords(String filter) {
     public static class GroupFilter extends AbstractListFilter<HIterationGroup>
             implements Serializable {
 
+        private static final long serialVersionUID = 5698872972627107893L;
         @Inject
         @Authenticated
         private HAccount authenticatedAccount;

diff --git a/server/services/src/main/java/org/zanata/action/DashboardUserStats.java b/server/services/src/main/java/org/zanata/action/DashboardUserStats.java
@@ -27,6 +27,7 @@
  * @author Alex Eng <a href="mailto:aeng@redhat.com">aeng@redhat.com</a>
  */
 public class DashboardUserStats implements Serializable {
+    private static final long serialVersionUID = -8754654703489035048L;
     private int wordsTranslated;
     private int messagesTranslated;
     private int documentsTranslated;

diff --git a/server/services/src/main/java/org/zanata/action/LanguageAction.java b/server/services/src/main/java/org/zanata/action/LanguageAction.java
@@ -118,6 +118,9 @@ public class LanguageAction implements Serializable {
     private AbstractListFilter<HLocaleMember> membersFilter =
             new InMemoryListFilter<HLocaleMember>() {
 
+                private static final long serialVersionUID =
+                        2623778070221385071L;
+
                 @Override
                 protected List<HLocaleMember> fetchAll() {
                     return localeMemberDAO

diff --git a/server/services/src/main/java/org/zanata/action/LanguageContactCoordinatorAction.java b/server/services/src/main/java/org/zanata/action/LanguageContactCoordinatorAction.java
@@ -50,6 +50,7 @@
 public class LanguageContactCoordinatorAction implements Serializable {
     private static final org.slf4j.Logger log = org.slf4j.LoggerFactory
             .getLogger(LanguageContactCoordinatorAction.class);
+    private static final long serialVersionUID = -4071108974519011187L;
 
     @Inject
     @Authenticated

diff --git a/server/services/src/main/java/org/zanata/action/MergeTransAction.java b/server/services/src/main/java/org/zanata/action/MergeTransAction.java
@@ -42,6 +42,7 @@
 @Transactional
 public class MergeTransAction extends CopyAction implements Serializable {
 
+    private static final long serialVersionUID = 3200057182420160982L;
     private String targetProjectSlug;
     private String targetVersionSlug;
     private String sourceProjectSlug;

diff --git a/server/services/src/main/java/org/zanata/action/OpenIdAction.java b/server/services/src/main/java/org/zanata/action/OpenIdAction.java
@@ -21,6 +21,7 @@
 @ViewScoped
 public class OpenIdAction implements Serializable {
 
+    private static final long serialVersionUID = 1681443557491913852L;
     @Inject
     private ZanataIdentity identity;
 

diff --git a/server/services/src/main/java/org/zanata/action/ProjectHome.java b/server/services/src/main/java/org/zanata/action/ProjectHome.java
@@ -227,6 +227,9 @@ private List<HLocale> findActiveNotEnabledLocales() {
     private AbstractListFilter<HPerson> maintainerFilter =
             new InMemoryListFilter<HPerson>() {
 
+                private static final long serialVersionUID =
+                        8259700829800303578L;
+
                 @Override
                 protected List<HPerson> fetchAll() {
                     return getInstanceMaintainers();
@@ -1187,6 +1190,7 @@ protected void updatedMessage() {
     public static class ProjectMaintainersAutocomplete
             extends MaintainerAutocomplete {
 
+        private static final long serialVersionUID = -6765972032876700000L;
         @Inject
         private ProjectHome projectHome;
         @Inject

diff --git a/server/services/src/main/java/org/zanata/action/ProjectHomeAction.java b/server/services/src/main/java/org/zanata/action/ProjectHomeAction.java
@@ -139,6 +139,9 @@ public class ProjectHomeAction extends AbstractSortAction
     private AbstractListFilter<HProjectIteration> versionFilter =
             new InMemoryListFilter<HProjectIteration>() {
 
+                private static final long serialVersionUID =
+                        7931445158995457207L;
+
                 @Override
                 protected List<HProjectIteration> fetchAll() {
                     return getProjectVersions();
@@ -723,6 +726,7 @@ public String apply(HLocale input) {
 
     public final class PeopleFilterComparator
             extends InMemoryListFilter<HPerson> implements Comparator<HPerson> {
+        private static final long serialVersionUID = 3905373873256076410L;
         private final ProjectRolePredicate projectRolePredicate =
                 new ProjectRolePredicate();
         private final ProjectLocalePredicate projectLocalePredicate =

diff --git a/server/services/src/main/java/org/zanata/action/ProjectPermissionDialog.java b/server/services/src/main/java/org/zanata/action/ProjectPermissionDialog.java
@@ -74,6 +74,7 @@ public class ProjectPermissionDialog extends AbstractAutocomplete<HPerson>
         implements Serializable {
     private static final org.slf4j.Logger log =
             org.slf4j.LoggerFactory.getLogger(ProjectPermissionDialog.class);
+    private static final long serialVersionUID = 2295330844926429686L;
 
     @Inject
     private FacesMessages facesMessages;

diff --git a/server/services/src/main/java/org/zanata/action/RoleAssignmentRuleId.java b/server/services/src/main/java/org/zanata/action/RoleAssignmentRuleId.java
@@ -35,6 +35,7 @@
 @GroupedConversationScoped
 @ConversationGroup(RoleAssignmentRuleId.class)
 public class RoleAssignmentRuleId implements Serializable {
+    private static final long serialVersionUID = -9139170676497744477L;
     private @Nullable Long id;
 
     public Long getId() {

diff --git a/server/services/src/main/java/org/zanata/action/SortingType.java b/server/services/src/main/java/org/zanata/action/SortingType.java
@@ -9,6 +9,7 @@
  * @author Alex Eng <a href="mailto:aeng@redhat.com">aeng@redhat.com</a>
  */
 public class SortingType implements Serializable {
+    private static final long serialVersionUID = -5844701953054739028L;
     @SuppressFBWarnings(value = "SE_BAD_FIELD")
     private SortOption selectedSortOption = SortOption.ALPHABETICAL;
     @SuppressFBWarnings(value = "SE_BAD_FIELD")

diff --git a/server/services/src/main/java/org/zanata/action/TranslationMemoryAction.java b/server/services/src/main/java/org/zanata/action/TranslationMemoryAction.java
@@ -200,6 +200,7 @@ public String cancel() {
     }
 
     private static class TMComparator implements Comparator<TransMemory>, Serializable {
+        private static final long serialVersionUID = 3057178464938604821L;
         private SortingType sortingType;
 
         public TMComparator(SortingType sortingType) {

diff --git a/server/services/src/main/java/org/zanata/action/UserAction.java b/server/services/src/main/java/org/zanata/action/UserAction.java
@@ -81,6 +81,9 @@ public class UserAction implements Serializable {
     private AbstractListFilter<String> userFilter =
             new AbstractListFilter<String>() {
 
+                private static final long serialVersionUID =
+                        6774670019241510582L;
+
                 @Override
                 protected List<String> fetchRecords(int start, int max,
                         String filter) {

diff --git a/server/services/src/main/java/org/zanata/action/UserSettingsAction.java b/server/services/src/main/java/org/zanata/action/UserSettingsAction.java
@@ -83,6 +83,7 @@
 public class UserSettingsAction implements Serializable {
     private static final org.slf4j.Logger log =
             org.slf4j.LoggerFactory.getLogger(UserSettingsAction.class);
+    private static final long serialVersionUID = 1937219523042662641L;
 
     @Inject
     private EmailService emailServiceImpl;

diff --git a/server/services/src/main/java/org/zanata/action/VersionGroupHome.java b/server/services/src/main/java/org/zanata/action/VersionGroupHome.java
@@ -100,6 +100,9 @@ public class VersionGroupHome extends SlugHome<HIterationGroup>
     private AbstractListFilter<HPerson> maintainerFilter =
             new InMemoryListFilter<HPerson>() {
 
+                private static final long serialVersionUID =
+                        6521717110985363677L;
+
                 @Override
                 protected List<HPerson> fetchAll() {
                     return getInstanceMaintainers();
@@ -291,6 +294,7 @@ public void validateSuppliedId() {
     public static class GroupMaintainerAutocomplete
             extends MaintainerAutocomplete {
 
+        private static final long serialVersionUID = 1150630837852918989L;
         @Inject
         private VersionGroupHome versionGroupHome;
         @Inject
@@ -331,6 +335,7 @@ public void onSelectItemAction() {
     public static class VersionAutocomplete
             extends AbstractAutocomplete<HProjectIteration> {
 
+        private static final long serialVersionUID = 8022275695197571957L;
         @Inject
         private ProjectIterationDAO projectIterationDAO;
         @Inject
@@ -384,6 +389,7 @@ public void onSelectItemAction() {
     @ViewScoped
     public static class GroupLocaleAutocomplete extends LocaleAutocomplete {
 
+        private static final long serialVersionUID = -4325912450531279919L;
         @Inject
         private VersionGroupHome versionGroupHome;
         @Inject

diff --git a/server/services/src/main/java/org/zanata/action/VersionGroupHomeAction.java b/server/services/src/main/java/org/zanata/action/VersionGroupHomeAction.java
@@ -107,6 +107,9 @@ public class VersionGroupHomeAction extends AbstractSortAction
     private final AbstractListFilter<HLocale> projectTabLanguageFilter =
             new InMemoryListFilter<HLocale>() {
 
+                private static final long serialVersionUID =
+                        7550100962201447662L;
+
                 @Override
                 protected List<HLocale> fetchAll() {
                     return getActiveLocales();
@@ -123,6 +126,9 @@ protected boolean include(HLocale elem, String filter) {
     private final AbstractListFilter<HLocale> languageTabLanguageFilter =
             new InMemoryListFilter<HLocale>() {
 
+                private static final long serialVersionUID =
+                        -5026649603666309838L;
+
                 @Override
                 protected List<HLocale> fetchAll() {
                     return getActiveLocales();
@@ -139,6 +145,9 @@ protected boolean include(HLocale elem, String filter) {
     private final AbstractListFilter<HProjectIteration> languageTabVersionFilter =
             new InMemoryListFilter<HProjectIteration>() {
 
+                private static final long serialVersionUID =
+                        -8992474540264340865L;
+
                 @Override
                 protected List<HProjectIteration> fetchAll() {
                     return getProjectIterations();
@@ -155,6 +164,9 @@ protected boolean include(HProjectIteration elem,
     private final AbstractListFilter<HProjectIteration> projectTabVersionFilter =
             new InMemoryListFilter<HProjectIteration>() {
 
+                private static final long serialVersionUID =
+                        1693725144619170657L;
+
                 @Override
                 protected List<HProjectIteration> fetchAll() {
                     return getProjectIterations();

diff --git a/server/services/src/main/java/org/zanata/action/VersionGroupJoinAction.java b/server/services/src/main/java/org/zanata/action/VersionGroupJoinAction.java
@@ -215,6 +215,7 @@ public void onSelectItemAction() {
     }
 
     public static final class SelectableVersion extends ProjectIterationId {
+        private static final long serialVersionUID = -1843985308720091486L;
         private boolean selected;
 
         public SelectableVersion(String projectSlug, String versionSlug,

diff --git a/server/services/src/main/java/org/zanata/action/VersionGroupSlug.java b/server/services/src/main/java/org/zanata/action/VersionGroupSlug.java
@@ -32,6 +32,7 @@
 @GroupedConversationScoped
 @ConversationGroup(SlugHome.class)
 public class VersionGroupSlug implements Serializable {
+    private static final long serialVersionUID = 991219281405201825L;
     private String value;
 
     public String getValue() {

diff --git a/server/services/src/main/java/org/zanata/action/VersionHomeAction.java b/server/services/src/main/java/org/zanata/action/VersionHomeAction.java
@@ -212,6 +212,9 @@ public class VersionHomeAction extends AbstractSortAction
     private final AbstractListFilter<HIterationGroup> groupFilter =
             new InMemoryListFilter<HIterationGroup>() {
 
+                private static final long serialVersionUID =
+                        -8985475801770776976L;
+
                 @Override
                 protected List<HIterationGroup> fetchAll() {
                     return getGroups();
@@ -228,6 +231,9 @@ protected boolean include(HIterationGroup elem, String filter) {
     private final AbstractListFilter<HLocale> languageTabLanguageFilter =
             new InMemoryListFilter<HLocale>() {
 
+                private static final long serialVersionUID =
+                        -1089546989875020588L;
+
                 @Override
                 protected List<HLocale> fetchAll() {
                     return getSupportedLocale();
@@ -244,6 +250,9 @@ protected boolean include(HLocale elem, String filter) {
     private final AbstractListFilter<HLocale> documentsTabLanguageFilter =
             new InMemoryListFilter<HLocale>() {
 
+                private static final long serialVersionUID =
+                        -3659763109918732037L;
+
                 @Override
                 protected List<HLocale> fetchAll() {
                     return getSupportedLocale();
@@ -302,6 +311,7 @@ public void triggerManualWebhookEvent() {
 
     public static class CopyVersionHandler extends CopyAction
             implements Serializable {
+        private static final long serialVersionUID = 7720904735608930337L;
         private String projectSlug;
         private String versionSlug;
         @Inject
@@ -1003,6 +1013,8 @@ public void clearTransFileUpload() {
 
     private class DocumentFilter extends InMemoryListFilter<HDocument> {
 
+        private static final long serialVersionUID = -4675800292403066019L;
+
         @Override
         protected List<HDocument> fetchAll() {
             return getDocuments(documentDAO);
@@ -1018,6 +1030,7 @@ protected boolean include(HDocument elem, String filter) {
 
     private class SourceDocumentFilter extends InMemoryListFilter<HDocument> {
 
+        private static final long serialVersionUID = 5939911285844999856L;
         private DocumentDAO documentDAO =
                 ServiceLocator.instance().getInstance(DocumentDAO.class);
 

diff --git a/server/services/src/main/java/org/zanata/async/AsyncTaskHandle.java b/server/services/src/main/java/org/zanata/async/AsyncTaskHandle.java
@@ -43,6 +43,7 @@
  */
 public class AsyncTaskHandle<V> implements Serializable {
 
+    private static final long serialVersionUID = -2896367626313653728L;
     @SuppressFBWarnings("SE_BAD_FIELD")
     private CompletableFuture<V> futureResult;
     public long maxProgress = 100;

diff --git a/server/services/src/main/java/org/zanata/async/handle/CopyTransTaskHandle.java b/server/services/src/main/java/org/zanata/async/handle/CopyTransTaskHandle.java
@@ -30,6 +30,7 @@
 public class CopyTransTaskHandle extends AsyncTaskHandle<Void> implements
         UserTriggeredTaskHandle {
 
+    private static final long serialVersionUID = -5896877101976333925L;
     private String triggeredBy;
     private boolean prepared;
 

diff --git a/server/services/src/main/java/org/zanata/async/handle/CopyVersionTaskHandle.java b/server/services/src/main/java/org/zanata/async/handle/CopyVersionTaskHandle.java
@@ -32,6 +32,7 @@
 public class CopyVersionTaskHandle extends AsyncTaskHandle<Void> implements
         UserTriggeredTaskHandle {
 
+    private static final long serialVersionUID = -3200117976693100638L;
     private int documentCopied;
     private int totalDoc;
     private String triggeredBy;

diff --git a/server/services/src/main/java/org/zanata/async/handle/TransMemoryMergeTaskHandle.java b/server/services/src/main/java/org/zanata/async/handle/TransMemoryMergeTaskHandle.java
@@ -33,6 +33,7 @@
  */
 public class TransMemoryMergeTaskHandle extends AsyncTaskHandle<Void> implements
         UserTriggeredTaskHandle {
+    private static final long serialVersionUID = 1704257523049053603L;
     private String triggeredBy;
     private String mergeTarget;
 

diff --git a/server/services/src/main/java/org/zanata/config/JaasConfig.java b/server/services/src/main/java/org/zanata/config/JaasConfig.java
@@ -38,6 +38,8 @@
 @javax.enterprise.context.ApplicationScoped
 public class JaasConfig implements Serializable {
 
+    private static final long serialVersionUID = -8707906261411142759L;
+
     /**
      * Retrieves all App configuration entries under a given name. In Jboss's
      * standalone.xml, these are all the {@code <login-module></login-module>}

diff --git a/server/services/src/main/java/org/zanata/config/SystemPropertyConfigStore.java b/server/services/src/main/java/org/zanata/config/SystemPropertyConfigStore.java
@@ -69,6 +69,7 @@ public class SystemPropertyConfigStore implements ConfigStore {
     private static final String KEY_SUPPORT_OAUTH = "zanata.support.oauth";
     private static final Logger log =
             LoggerFactory.getLogger(SystemPropertyConfigStore.class);
+    private static final long serialVersionUID = 1086764656937071302L;
 
     @Override
     public String get(String propertyName) {

diff --git a/server/services/src/main/java/org/zanata/dao/AccountActivationKeyDAO.java b/server/services/src/main/java/org/zanata/dao/AccountActivationKeyDAO.java
@@ -31,6 +31,8 @@
 public class AccountActivationKeyDAO extends
         AbstractDAOImpl<HAccountActivationKey, String> {
 
+    private static final long serialVersionUID = -2780971657155151510L;
+
     public AccountActivationKeyDAO() {
         super(HAccountActivationKey.class);
     }

diff --git a/server/services/src/main/java/org/zanata/dao/AccountDAO.java b/server/services/src/main/java/org/zanata/dao/AccountDAO.java
@@ -33,6 +33,8 @@
 @RequestScoped
 public class AccountDAO extends AbstractDAOImpl<HAccount, Long> {
     public static final String REGION = "Account";
+    private static final long serialVersionUID = -2710311827560778973L;
+
     public AccountDAO() {
         super(HAccount.class);
     }

diff --git a/server/services/src/main/java/org/zanata/dao/AccountOptionDAO.java b/server/services/src/main/java/org/zanata/dao/AccountOptionDAO.java
@@ -29,6 +29,8 @@
 @Named("accountOptionDAO")
 @RequestScoped
 public class AccountOptionDAO extends AbstractDAOImpl<HAccountOption, Long> {
+    private static final long serialVersionUID = 886034475613575773L;
+
     public AccountOptionDAO() {
         super(HAccountOption.class);
     }