refactor(actions): use string action type for DIFF_SETTING_CHANGED

zanata · Oct 12, 2017 · a266308 · a266308
1 parent db498aa
commit a266308
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/server/zanata-frontend/src/frontend/app/editor/actions/suggestions-action-types.js b/server/zanata-frontend/src/frontend/app/editor/actions/suggestions-action-types.js
@@ -1,4 +1,5 @@
-export const DIFF_SETTING_CHANGED = Symbol('DIFF_SETTING_CHANGED')
+// FIXME this should probably be called TOGGLE_DIFF_SETTING or similar
+export const DIFF_SETTING_CHANGED = 'DIFF_SETTING_CHANGED'
 export const SET_SUGGESTION_SEARCH_TYPE = Symbol('SET_SUGGESTION_SEARCH_TYPE')
 export const RESET_SUGGESTIONS_COPYING = Symbol('RESET_SUGGESTIONS_COPYING')
 // FIXME may be unused

diff --git a/server/zanata-frontend/src/frontend/app/editor/actions/suggestions-actions.js b/server/zanata-frontend/src/frontend/app/editor/actions/suggestions-actions.js
@@ -48,9 +48,7 @@ export function togglePhraseSuggestions () {
   }
 }
 
-export function diffSettingChanged () {
-  return { type: DIFF_SETTING_CHANGED }
-}
+export const diffSettingChanged = createAction(DIFF_SETTING_CHANGED)
 
 export function clearSearch () {
   return changeSearchText('')