refactor(actions): simplify payload of SET_GLOSSARY_DETAILS_INDEX

zanata · Sep 22, 2017 · b5c9122 · b5c9122
1 parent 184d6ea
commit b5c9122
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 11 deletions.
diff --git a/server/zanata-frontend/src/frontend/app/editor/actions/glossary-action-types.js b/server/zanata-frontend/src/frontend/app/editor/actions/glossary-action-types.js
@@ -9,7 +9,7 @@ export const GLOSSARY_TERMS_SUCCESS = 'GLOSSARY_TERMS_SUCCESS'
 export const GLOSSARY_TERMS_FAILURE = 'GLOSSARY_TERMS_FAILURE'
 
 /* Indicates the index in glossary results that should have details displayed */
-export const SET_GLOSSARY_DETAILS_INDEX = Symbol('SET_GLOSSARY_DETAILS_INDEX')
+export const SET_GLOSSARY_DETAILS_INDEX = 'SET_GLOSSARY_DETAILS_INDEX'
 /* Set whether glossary details modal is showing */
 export const SHOW_GLOSSARY_DETAILS = Symbol('SHOW_GLOSSARY_DETAILS')
 

diff --git a/server/zanata-frontend/src/frontend/app/editor/actions/glossary-actions.js b/server/zanata-frontend/src/frontend/app/editor/actions/glossary-actions.js
@@ -104,12 +104,7 @@ function findGlossaryTerms (searchText) {
   }
 }
 
-function setGlossaryDetailsIndex (index) {
-  return {
-    type: SET_GLOSSARY_DETAILS_INDEX,
-    payload: { index }
-  }
-}
+const setGlossaryDetailsIndex = createAction(SET_GLOSSARY_DETAILS_INDEX)
 
 export function showGlossaryDetails (show) {
   return {

diff --git a/server/zanata-frontend/src/frontend/app/editor/reducers/glossary-reducer.js b/server/zanata-frontend/src/frontend/app/editor/reducers/glossary-reducer.js
@@ -104,7 +104,7 @@ const glossary = (state = defaultState, action) => {
     case SET_GLOSSARY_DETAILS_INDEX:
       return update({
         details: {
-          resultIndex: {$set: action.payload.index}
+          resultIndex: {$set: action.payload}
         }
       })
 

diff --git a/server/zanata-frontend/src/frontend/app/editor/reducers/glossary-reducer.test.js b/server/zanata-frontend/src/frontend/app/editor/reducers/glossary-reducer.test.js
@@ -196,9 +196,7 @@ describe('glossary-reducer test', () => {
     const initial = glossaryReducer(undefined, { type: 'any' })
     const withIndex = glossaryReducer(initial, {
       type: SET_GLOSSARY_DETAILS_INDEX,
-      payload: {
-        index: 5
-      }
+      payload: 5
     })
     expect(initial.details.resultIndex).toEqual(0)
     expect(withIndex.details.resultIndex).toEqual(5)