Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle old rest endpoint #489

Merged
merged 1 commit into from Aug 22, 2017
Merged

fix: handle old rest endpoint #489

merged 1 commit into from Aug 22, 2017

Conversation

alex-sl-eng
Copy link
Member

@alex-sl-eng alex-sl-eng commented Aug 22, 2017

https://zanata.atlassian.net/browse/ZNTA-2178

JIRA issue URL: paste URL here

[Add a short description of what is changed here.]

Reviewer tasks

The following is based on the
Zanata Development Guidelines.
As a reviewer, you should check the guidelines regularly for updates, and just
to refresh your memory.

The reviewer can use this list for reference to make sure
they have considered all the important points.

Use the checkboxes or not, whatever works best for you.

  • Code quality
    • Code passes style check (checkstyle/eslint)
    • Code is clear and concise
    • UI code is internationalised
    • Code has adequate comments where appropriate
    • Code is in an appropriate place
      • Classes are in appropriate packages
      • Code fits with class's responsibilities (SRP)
    • Configuration files are documented enough
    • If code is removed
      • No remaining code references the removed code
        • No orphaned rewrite rules
        • No orphaned config settings
      • No remaining comments refer to the removed code
      • Unused imports and libraries are removed
  • Testing
    • New code has tests
    • Changed code has tests
    • All tests pass
    • Test coverage stable or increased
  • Documentation
    • New features are documented
    • Docs removed for deleted features
    • Docs updated for all changed features
    • Developer/sysadmin docs updated if appropriate
  • If there are new dependencies

This template can be updated in .github/PULL_REQUEST_TEMPLATE.md


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 22, 2017

Codecov Report

Merging #489 into master will decrease coverage by 0.01%.
The diff coverage is 23.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #489      +/-   ##
============================================
- Coverage     32.95%   32.94%   -0.02%     
  Complexity     5629     5629              
============================================
  Files          1534     1534              
  Lines         64854    64859       +5     
  Branches       7364     7364              
============================================
- Hits          21375    21370       -5     
- Misses        41596    41613      +17     
+ Partials       1883     1876       -7
Impacted Files Coverage Δ Complexity Δ
...a/org/zanata/rest/client/ResponseStatusFilter.java 13.63% <0%> (ø) 4 <0> (ø) ⬇️
...g/zanata/rest/client/StatisticsResourceClient.java 71.92% <0%> (-1.76%) 5 <0> (ø)
...rg/zanata/rest/client/SourceDocResourceClient.java 53.62% <14.28%> (-6.08%) 6 <0> (ø)
...org/zanata/rest/client/TransDocResourceClient.java 62.85% <27.77%> (-2.86%) 3 <0> (ø)
...ava/org/zanata/rest/client/AsyncProcessClient.java 45.78% <46.15%> (-1.72%) 4 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5057f6f...b61488e. Read the comment docs.

@alex-sl-eng
Copy link
Member Author

The issue can be reproduced by using 4.3.0-SNAPSHOT client (pull) against older Zanata server (e.g. translate.zanata.org)

@spathare21 spathare21 added Verified and removed On QA labels Aug 22, 2017
@alex-sl-eng alex-sl-eng merged commit 7db38f9 into master Aug 22, 2017
@alex-sl-eng alex-sl-eng deleted the ZNTA-2178 branch August 22, 2017 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants