New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reduce imports for react-sytax-highlighter #665
Conversation
Reviewed 1 of 1 files at r1. Comments from Reviewable |
@efloden please check the failed jenkins build. |
…en/refactor-highlightjs-imports
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
============================================
+ Coverage 33.14% 33.2% +0.06%
- Complexity 5775 11568 +5793
============================================
Files 1575 3152 +1577
Lines 62267 124752 +62485
Branches 7351 14745 +7394
============================================
+ Hits 20638 41425 +20787
- Misses 39706 79454 +39748
- Partials 1923 3873 +1950
Continue to review full report at Codecov.
|
@aeng build passing now |
@efloden probably its a good idea to increase the test coverage for this component. |
Reviewed 2 of 2 files at r2. Comments from Reviewable |
JIRA issue URL: N/A
Reduces the import footprint of the react-syntax-highlighter significantly by only importing the xml language. (which is all we are using at the moment)
Checklist
See Zanata Development Guidelines more for information.
This template can be updated in .github/PULL_REQUEST_TEMPLATE.md
This change is