fix(ZNTA-2313): update admin rejection panel

[ghost]

JIRA issue URL: https://zanata.atlassian.net/browse/ZNTA-2313

Removed the accordion with the text input rows. This is kind of confusing since these can't be used as a starting point without copying the text so the examples have been included as text under the description.

The toggle editable button is removed as it isn't necessary. If admins want to change the criteria they can just edit it, and if they aren't happy with their changes they shouldn't save them.

Also fixed padding and spacing in the rows and added breadcrumbs as requested.

QA

Please test the functionality of the admin Reject Criteria page in frontend

Initial page

Add first criteria

Add second criteria

Modal - criteria added

Modal - no criteria added

Checklist

• JIRA link
• Check target branch
• Make sure all commit statuses are green or otherwise documented reasons to ignore
• QA needs to evaluate against the JIRA ticket
• Changed files and commits make sense for this PR

See Zanata Development Guidelines more for information.

---

This template can be updated in .github/PULL_REQUEST_TEMPLATE.md

---

This change is 

[codecov]

Codecov Report

Merging #672 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #672      +/-   ##
============================================
+ Coverage     35.24%   35.25%   +<.01%     
  Complexity     5813     5813              
============================================
  Files          1586     1587       +1     
  Lines         62761    62768       +7     
  Branches       7297     7298       +1     
============================================
+ Hits          22123    22130       +7     
  Misses        38688    38688              
  Partials       1950     1950

Impacted Files	Coverage Δ	Complexity Δ
.../editor/components/RejectTranslationModal/index.js	88.88% <100%> (ø)	0 <0> (ø)	⬇️
...ctTranslationModal/RejectTranslationModalNoCrit.js	100% <100%> (ø)	0 <0> (?)
...zanata-frontend/src/app/containers/Admin/Review.js	31.03% <60%> (-4.45%)	0 <0> (ø)
...rontend/src/app/components/RejectionsForm/index.js	80% <75%> (+0.45%)	0 <0> (ø)	⬇️
...main/java/org/zanata/servlet/UrlRewriteConfig.java	79.24% <0%> (-0.2%)	4% <0%> (ø)
server/zanata-frontend/src/app/containers/Root.js	50% <0%> (ø)	0% <0%> (ø)	⬇️
.../zanata-frontend/src/app/containers/Admin/index.js	42.85% <0%> (ø)	0% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38d758...ffc85ae. Read the comment docs.

[efloden]

Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[efloden]

[djansen-redhat]

• The "editable toggle" I believe actually referred to the use of the option in the editor - in that it means text in the rejection field will be appended to the criteria reason. If not editable, then that text will be ignored.
• No indication of save success
• 500 Server error on attempting to delete a used criteria (!?) - ZNTA-2359
• No field max sizing, 500 server error on too much text - ZNTA-2361
• No title/tooltip for 'Delete criteria'
• TextArea can be resized beyond the parent container, resulting in clipped buttons. Should just be a TextField anyhow.
• Can save a criteria without text - ZNTA-2360
• The parentheses seem unnecessary, it could just be eg Translation Errors: terminology, mistranslated, etc
• Not sure if it matters at all, but the design is dissimilar to the "centred column" of the other admin pages
• Deletion confirmation?

Not directly related:

• The amount of text that can be entered causes the dropdown in the editor to extend well past the page
• Empty text still shows in the dropdown (edit: fixed in ZNTA-2360)

[ghost]

The "editable toggle" I believe actually referred to the use of the option in the editor - in that it means text in the rejection field will be appended to the criteria reason. If not editable, then that text will be ignored.

• is this even necessary? Seems to overcomplicate the UI and surely the field can be ignored if there is not text and any text in the rejection field will be appended anyways.

No indication of save success

• use Alert - success to do this
• Kathryn to add example to storybook

500 Server error on attempting to delete a used criteria (!?)

• good luck with that one

No field max sizing, 500 server error on too much text

• Kathryn to fix

No title/tooltip for 'Delete criteria'

• Kathryn to fix

TextArea can be resized beyond the parent container, resulting in clipped buttons. Should just be a TextField anyhow.

• Kathryn to fix

Can save a criteria without text

• another one for the engineers

The parentheses seem unnecessary, it could just be eg Translation Errors: terminology, mistranslated, etc

• Kathryn to fix

Not sure if it matters at all, but the design is dissimilar to the "centred column" of the other admin pages

• more content, needs a wider view

Deletion confirmation?

• Kathryn to fix

Not directly related:

The amount of text that can be entered causes the dropdown in the editor to extend well past the page

• Kathryn to fix

Empty text still shows in the dropdown

• Unsure what I can do about this one

---

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[ghost]

Review status: 8 of 10 files reviewed at latest revision, 1 unresolved discussion.

---

server/zanata-frontend/src/app/editor/components/RejectTranslationModal/RejectTranslationModalNoCrit.js, line 6 at r9 (raw file):

Previously, efloden (Earl Floden) wrote…

Some unused imports and variables appear to cause the build failure in this file: (Dropdown, Icon, key, className, onHide, isOpen etc in the build logs)

Done.

---

Comments from Reviewable

[efloden]

Reviewed 1 of 1 files at r10, 1 of 1 files at r11.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[djansen-redhat]

eslint error: editableToggle is defined but not used

[ghost]

Review status: 5 of 9 files reviewed at latest revision, 1 unresolved discussion.

---

server/zanata-frontend/src/app/components/RejectionsForm/index.js, line 125 at r12 (raw file):

Previously, djansen-redhat (Damian Jansen) wrote…

eslint error: editableToggle is defined but not used

Done.

---

Comments from Reviewable

[spathare21]

@kathryngo

• Seems like few issues mentioned by Damian in above comment are not fixed
  fix(ZNTA-2313): update admin rejection panel #672 (comment)

• 500 internal server error on deleting Criteria

• 400 bad request on adding review criteria which contains lot of text (there should be limitation of characters in review criteria text box)

[djansen-redhat]

Reviewed 2 of 4 files at r12, 1 of 2 files at r13, 2 of 2 files at r14.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[djansen-redhat]

@spathare21 at this present moment the Operation Failed notice can stay. We can consider a fix later.
@kathryngo @efloden agree?

[ghost]

@djansen-redhat agreed

[ghost]

@djansen-redhat ready to verify?

[spathare21]

@djansen-redhat ok thanks then verifying it again if anything is missing

[ghost]

will merge after full func. tests are run

[djansen-redhat]

Reviewed 1 of 2 files at r15.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable