Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure appserver using Nashorn script #755

Merged
merged 3 commits into from
Mar 16, 2018
Merged

Configure appserver using Nashorn script #755

merged 3 commits into from
Mar 16, 2018

Conversation

seanf
Copy link
Contributor

@seanf seanf commented Mar 15, 2018

No description provided.

@zubot
Copy link
Member

zubot commented Mar 15, 2018

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 15, 2018

Codecov Report

Merging #755 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #755   +/-   ##
========================================
  Coverage      33.7%   33.7%           
  Complexity     5827    5827           
========================================
  Files          1593    1593           
  Lines         63583   63583           
  Branches       7416    7416           
========================================
  Hits          21428   21428           
  Misses        40202   40202           
  Partials       1953    1953

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7683acc...3dfba10. Read the comment docs.

@huangp
Copy link
Contributor

huangp commented Mar 16, 2018

:lgtm: +Reviewed +(No QA (1st vote))


Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@definite
Copy link
Member

:lgtm:


Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@seanf seanf merged commit 3fcf5bb into master Mar 16, 2018
@seanf seanf deleted the jboss-cli-jjs branch March 16, 2018 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants