Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download only those which have translations #48

Merged
merged 2 commits into from
Oct 7, 2016
Merged

Conversation

sdp5
Copy link
Collaborator

@sdp5 sdp5 commented Oct 5, 2016

Bug 1368381 - zanata pull downloads all .po files, even those which have no translations at all.

@definite Please have a look.


This change is Reviewable

@definite
Copy link
Member

definite commented Oct 6, 2016

Actually option --noskeletons is exactly for this purpose. If you want to make this default, I suggest you create an option --create-skeletons which is compatible with java client.

Copy link
Member

@definite definite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure use min_doc_percent to download non-empty translations work, as it may introduce round off problem

@sdp5
Copy link
Collaborator Author

sdp5 commented Oct 6, 2016

@definite You may please resume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants