Revert FilterConstraints includeStates(ActiveStates) to old behaviour

    Old behaviour was to flip all states to on in the case that they
    were all off. The change should only be temporary since it is
    surprising - some changes to the code for the editor are necessary
    before this can be made more sensible.

zanata-war/src/main/java/org/zanata/search/FilterConstraints.java

@@ -142,7 +142,18 @@ public Builder checkInTarget(boolean check)
 
       public Builder includeStates(ActiveStates states)
       {
-         this.states.fromStates(states);
+         //FIXME this behaviour is too surprising.
+         // It exists because the editor UI should show all states when either
+         // all or none of the states are checked. This logic should just happen
+         // in the editor backend *before* sending a request to the server.
+         if (states.hasNoStates())
+         {
+            this.states.allOn();
+         }
+         else
+         {
+            this.states.fromStates(states);
+         }
          return this;
       }