fix(login redirect): preserves hash location after login (#1228)

fix(profile): redirect to login is user not logged in

https://zanata.atlassian.net/browse/ZNTA-1051

frontend/src/main/web/src/actions/profile.js

@@ -91,8 +91,15 @@ const getUserInfo = (dispatch, username, dateRangeOption) => {
 
 export const profileInitialLoad = (username) => {
   return (dispatch, getState) => {
-    dispatch(getUserInfo(dispatch, username || window.config.user.username,
-      getState().profile.dateRangeOption))
+    const config = window.config
+    if (isEmpty(username) && !config.permission.isLoggedIn) {
+      // redirect to login screen if no username is found url
+      // and user is not logged in
+      window.location = config.baseUrl + config.links.loginUrl + '#profile'
+    } else {
+      dispatch(getUserInfo(dispatch, username,
+        getState().profile.dateRangeOption))
+    }
   }
 }
 

frontend/src/main/web/src/containers/UserProfile/index.jsx

@@ -50,7 +50,10 @@ const classes = {
 class UserProfile extends Component {
 
   componentDidMount () {
-    this.props.handleInitLoad(this.props.params.username)
+    const paramUsername = this.props.params.username
+    const username = (!paramUsername || paramUsername === 'undefined')
+      ? undefined : paramUsername
+    this.props.handleInitLoad(username)
   }
 
   render () {

frontend/src/main/web/webpack.config.js

@@ -40,5 +40,9 @@ module.exports = {
   },
   node: {
     __dirname: true
+  },
+  eslint: {
+    failOnWarning: false,
+    failOnError: true
   }
 }

zanata-war/src/main/webapp/account/login.xhtml

@@ -20,6 +20,15 @@
         var usernameFieldId = "[id='#{rich:clientId('username')}']";
         jQuery(usernameFieldId).focus()
       })
+
+      /**
+       * enforce hash location by appending the hash lication to the current
+       * action so that it persists to the redirected URL.
+       */
+      function onLogin(form) {
+        form.action = form.action + window.location.hash;
+        return true;
+      }
     </script>
 
     <div class="header__logo-only">
@@ -62,7 +71,7 @@
               </ui:fragment>
 
               <h:form id="loginForm"
-                styleClass="l--push-top-half l--pad-all-1 bg--pop-higher">
+                styleClass="l--push-top-half l--pad-all-1 bg--pop-higher" onsubmit="return onLogin(this)">
                 <div class="l--clearfix">
                   <h:outputLabel for="username"
                     styleClass="l--float-left">#{msgs['jsf.Username']}</h:outputLabel>