Implement fix from https://bugzilla.redhat.com/show_bug.cgi?id=100606…

…3#c2, item: I, II
zanata · Sep 26, 2013 · 2f291ef · huangp · Sep 26, 2013 · huangp
1 parent ce26a5c
commit 2f291ef
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 3 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/resources/UiMessages.java b/zanata-war/src/main/java/org/zanata/webtrans/client/resources/UiMessages.java
@@ -189,4 +189,7 @@ public interface UiMessages extends Messages
 
    @DefaultMessage("Highlight matches")
    String diffModeAsHighlight();
+
+   @DefaultMessage("Translation that contained validation warning or error.")
+   String invalidTooltip();
 }
diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/ui/ValidationWarningPanel.java b/zanata-war/src/main/java/org/zanata/webtrans/client/ui/ValidationWarningPanel.java
@@ -110,7 +110,7 @@ public void onClick(ClickEvent event)
          public void onClick(ClickEvent event)
          {
             hide();
-            listener.setFocus();
+            listener.setSelected(transUnitId);
          }
       });
    }

diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsDisplay.java b/zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsDisplay.java
@@ -108,7 +108,7 @@ interface Listener
 
       void rejectTranslation(TransUnitId id);
 
-      void setFocus();
+      void setSelected(TransUnitId transUnitId);
    }
 
    enum EditingState

diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransFilterView.java b/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransFilterView.java
@@ -76,6 +76,7 @@ public TransFilterView(UiMessages messages)
       hintMessage = messages.findSourceOrTargetString();
       searchField.setTextBoxTitle(hintMessage);
       initWidget(uiBinder.createAndBindUi(this));
+      hasErrorChk.setTitle(messages.invalidTooltip());
       getElement().setId("TransFilterView");
    }
 

diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransFilterView.ui.xml b/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransFilterView.ui.xml
@@ -175,7 +175,7 @@
 			</li>
 
 			<li class="{style.drop-down}">
-				<g:CheckBox ui:field="hasErrorChk" styleName="{style.hasError} {style.checkbox}"><ui:msg>Has warning</ui:msg></g:CheckBox>
+				<g:CheckBox ui:field="hasErrorChk" styleName="{style.hasError} {style.checkbox}"><ui:msg>Invalid</ui:msg></g:CheckBox>
 			</li>
 		</ul>
 	</g:HTMLPanel>