Fix findbugs warnings

zanata · Oct 3, 2013 · 397bc7e · huangp · Oct 8, 2013 · seanf
1 parent 68bf669
commit 397bc7e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 1 deletion.
diff --git a/zanata-model/src/main/java/org/zanata/hibernate/search/ConfigurableNgramAnalyzer.java b/zanata-model/src/main/java/org/zanata/hibernate/search/ConfigurableNgramAnalyzer.java
@@ -69,6 +69,7 @@ public ConfigurableNgramAnalyzer(int ngramMinLength, int ngramMaxLength,
         this.foldCase = foldCase;
     }
 
+    @SuppressWarnings("resource") // caller should close
     @Override
     public TokenStream tokenStream(String fieldName, Reader reader) {
         TokenStream tokenStream;

diff --git a/zanata-war/src/main/java/org/zanata/action/ReindexAsyncBean.java b/zanata-war/src/main/java/org/zanata/action/ReindexAsyncBean.java
@@ -193,7 +193,7 @@ public Boolean call() throws Exception {
             // look at updating isInProgress not to care about count
             if (getHandle().getMaxProgress() == 0) {
                 log.info("Reindexing aborted because there are no actions to perform (may be indexing an empty table)");
-                return null;
+                return false;
             }
             for (Class<?> clazz : indexables) {
                 if (!getHandle().isCancelled()

diff --git a/zanata-war/src/main/java/org/zanata/seam/FixedSafeActions.java b/zanata-war/src/main/java/org/zanata/seam/FixedSafeActions.java
@@ -35,6 +35,7 @@
 // Implementation copied from
 // https://source.jboss.org/browse/Seam/branches/community/Seam_2_3/jboss-seam/src/main/java/org/jboss/seam/navigation/SafeActions.java?r=14141
 // following https://community.jboss.org/message/688860#688860
+// TODO see if this can be removed - see also https://issues.jboss.org/browse/JBSEAM-4800
 public class FixedSafeActions extends org.jboss.seam.navigation.SafeActions {
 
     private Set<String> safeActions = Collections

diff --git a/zanata-war/src/test/java/com/google/gwt/core/client/GWTBridge.java b/zanata-war/src/test/java/com/google/gwt/core/client/GWTBridge.java
@@ -1,5 +1,7 @@
 package com.google.gwt.core.client;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 /**
  * After upgrade to GWT 2.5, some of the gwt related libraries start to break.
  * i.e. gwt-log see http://code.google.com/p/gwt-log/issues/detail?id=70
@@ -11,5 +13,6 @@
  * @author Patrick Huang <a
  *         href="mailto:pahuang@redhat.com">pahuang@redhat.com</a>
  */
+@SuppressFBWarnings("NM_SAME_SIMPLE_NAME_AS_SUPERCLASS")
 public abstract class GWTBridge extends com.google.gwt.core.shared.GWTBridge {
 }