Sort by percent approved as double, not int

zanata · Oct 3, 2013 · 535b2e7 · 535b2e7
1 parent 29d10f4
commit 535b2e7
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/action/ViewAllStatusAction.java b/zanata-war/src/main/java/org/zanata/action/ViewAllStatusAction.java
@@ -162,15 +162,16 @@ public Status(String locale, String nativeName,
 
         @Override
         public int compareTo(Status o) {
-            int per =
-                    getStats().getTotal() == 0 ? 0 : (int) Math.ceil(100.0
-                            * getStats().getApproved() / getStats().getTotal());
-            int comparePer =
-                    o.getStats().getTotal() == 0 ? 0 : (int) Math.ceil(100.0
-                            * o.getStats().getApproved()
-                            / o.getStats().getTotal());
-
-            return Double.compare(comparePer, per);
+            // TODO compare by locale too?
+            // TODO if totals are the same, we only need to compare approved
+            return Double.compare(o.getPercentApproved(), getPercentApproved());
+        }
+
+        private double getPercentApproved() {
+            // TODO move to TranslationStatistics.getPercentApproved() ?
+            long total = getStats().getTotal();
+            long approved = getStats().getApproved();
+            return total == 0 ? 0 : 100d * approved / total;
         }
     }