Merge pull request #175 from zanata/rhbz1002340-openid-username

rhbz1002340 - prevent ajax race condition
zanata · Sep 12, 2013 · 65f5bb8 · 65f5bb8
2 parents bf11906 + 1204fe5
commit 65f5bb8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/action/ProfileAction.java b/zanata-war/src/main/java/org/zanata/action/ProfileAction.java
@@ -121,12 +121,6 @@ private void validateUsername(String username)
       }
    }
 
-   public void verifyUsernameAvailable(ValueChangeEvent e)
-   {
-      String username = (String) e.getNewValue();
-      validateUsername(username);
-   }
-
    @Create
    public void onCreate()
    {

diff --git a/zanata-war/src/main/webapp/profile/edit.xhtml b/zanata-war/src/main/webapp/profile/edit.xhtml
@@ -36,9 +36,8 @@
             </ui:remove>
             <s:decorate id="usernameField" template="../WEB-INF/layout/edit.xhtml" rendered="#{profileAction.newUser}" enclose="true">
               <ui:define name="label">#{messages['jsf.Username']}</ui:define>
-              <h:inputText id="username" value="#{profileAction.username}" required="true"
-                           valueChangeListener="#{profileAction.verifyUsernameAvailable}" onchange="submit()" >
-                  <a4j:ajax event="blur" render="usernameField" execute="@this"/>
+              <h:inputText id="username" value="#{profileAction.username}" required="true">
+                <a4j:ajax event="blur" render="usernameField" execute="@this"/>
               </h:inputText>
 
               <s:span styleClass="icon-info-circle-2 input_help" id="usernameHelp">