Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Commit

Permalink
add TODOs for tasks in DocumentUploadUtil
Browse files Browse the repository at this point in the history
  • Loading branch information
davidmason committed Jul 19, 2013
1 parent e48634b commit 9848834
Showing 1 changed file with 4 additions and 1 deletion.
Expand Up @@ -66,6 +66,8 @@ public class DocumentUploadUtil

@In
private ZanataIdentity identity;

// TODO technical debt: use entityManager
@In
private Session session;
@In
Expand All @@ -75,6 +77,7 @@ public class DocumentUploadUtil
@In
private TranslationFileService translationFileServiceImpl;

// TODO damason: move all validation checks to separate class
public void failIfUploadNotValid(GlobalDocumentId id, DocumentFileUploadForm uploadForm)
throws ChunkUploadException
{
Expand Down Expand Up @@ -212,7 +215,7 @@ protected HDocumentUpload saveUploadPart(GlobalDocumentId id,

private HDocumentUpload retrieveUploadObject(DocumentFileUploadForm uploadForm)
{
// TODO put in DAO
// TODO damason: move to DAO (maybe DocumentDAO)
Criteria criteria = session.createCriteria(HDocumentUpload.class);
criteria.add(Restrictions.idEq(uploadForm.getUploadId()));
HDocumentUpload upload = (HDocumentUpload) criteria.uniqueResult();
Expand Down

0 comments on commit 9848834

Please sign in to comment.