Code review changes (See below).

Refactor method to use ternary operator. Assume a non-nullable argument in copy trans internal method.
zanata · Sep 4, 2013 · d1dae05 · d1dae05
1 parent 2832102
commit d1dae05
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/service/impl/CopyTransServiceImpl.java b/zanata-war/src/main/java/org/zanata/service/impl/CopyTransServiceImpl.java
@@ -375,11 +375,7 @@ ContentState determineContentState(boolean contextMatches, boolean projectMatche
     */
    static boolean shouldReject(boolean match, HCopyTransOptions.ConditionRuleAction action )
    {
-      if( !match && action == REJECT )
-      {
-         return true;
-      }
-      return false;
+      return !match && action == REJECT;
    }
 
    /**
@@ -499,7 +495,7 @@ private void copyTransForLocale(HDocument document, HLocale locale, HCopyTransOp
     */
    private static boolean shouldOverwrite(HTextFlowTarget currentlyStored, ContentState matchState)
    {
-      if( matchState == null || matchState == New )
+      if( matchState == New )
       {
          return false;
       }