Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Commit

Permalink
do not show people as project members when they have no roles
Browse files Browse the repository at this point in the history
People were being temporarily shown in the project list with no roles when
they should have been completely removed. It was just a caching issue with
the people sorting object.
  • Loading branch information
davidmason committed Aug 17, 2015
1 parent fc6824b commit d7ea646
Showing 1 changed file with 9 additions and 0 deletions.
Expand Up @@ -791,6 +791,11 @@ public void savePermissionDialogSelections() {
personRoles = null;
personLocaleRoles = null;
project = null;

// Person may have no roles left and no longer belong in the list, so
// ensure the list of people is refreshed.
peopleFilterComparator.clearAllMembers();
peopleFilterComparator.sortPeopleList();
}


Expand Down Expand Up @@ -838,6 +843,10 @@ protected List<HPerson> fetchAll() {
return allMembers;
}

public void clearAllMembers() {
allMembers = null;
}

@Override
protected boolean include(HPerson person, final String filter) {
if(StringUtils.isBlank(filter)) {
Expand Down

0 comments on commit d7ea646

Please sign in to comment.