rhbz1183994 - add index on lastModifiedBy column and fail on invalid …

…timezone
zanata · Mar 19, 2015 · da5ac91 · da5ac91
1 parent 697b4c6
commit da5ac91
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/rest/service/DateRange.java b/zanata-war/src/main/java/org/zanata/rest/service/DateRange.java
@@ -38,14 +38,12 @@ static DateRange from(String dateRangeParam, String fromTimezoneId) {
         if (dateRange.length != 2) {
             throw new InvalidDateParamException(dateRangeParam);
         }
-        // here we use java util timezone first because it supports more short IDs
         DateTimeZone zone;
         if (fromTimezoneId == null) {
             zone = DateTimeZone.getDefault();
         } else {
             try {
-                zone =
-                        DateTimeZone.forTimeZone(TimeZone.getTimeZone(fromTimezoneId));
+                zone = DateTimeZone.forID(fromTimezoneId);
             } catch (IllegalArgumentException e) {
                 throw new BadRequestException("Invalid timezone ID:" + fromTimezoneId);
             }

diff --git a/zanata-war/src/main/resources/db/changelogs/db.changelog-3.7.xml b/zanata-war/src/main/resources/db/changelogs/db.changelog-3.7.xml
@@ -48,6 +48,16 @@
     </createIndex>
   </changeSet>
 
+  <changeSet id="3" author="pahuang@redhat.com">
+    <comment>add indexes to HTextFlowTargetHistory and HTextFlowTarget table</comment>
+    <createIndex tableName="HTextFlowTargetHistory" indexName="Idx_lastModifiedBy">
+      <column name="last_modified_by_id"/>
+    </createIndex>
+    <createIndex tableName="HTextFlowTarget" indexName="Idx_lastModifiedBy">
+      <column name="last_modified_by_id"/>
+    </createIndex>
+  </changeSet>
+
   <changeSet id="3" author="aeng@redhat.com">
     <comment>Add revisionComment to HTextFlowTarget, HTextFlowTargetHistory</comment>
     <addColumn tableName="HTextFlowTarget">