reload entity within async task to avoid lazy initialization exception

zanata · Nov 15, 2013 · e426781 · e426781
1 parent dcab905
commit e426781
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/async/AsynchronousTaskExecutor.java b/zanata-war/src/main/java/org/zanata/async/AsynchronousTaskExecutor.java
@@ -76,9 +76,8 @@ public void execute() {
                     task.getHandle().set(returnValue);
                 } catch (Exception t) {
                     task.getHandle().setException(t);
-                    AsynchronousTaskExecutor.log
-                            .debug("Exception when executing an asynchronous task.",
-                                    t);
+                    log.error(
+                        "Exception when executing an asynchronous task.", t);
                 }
             }
 

diff --git a/zanata-war/src/main/java/org/zanata/service/impl/TranslationServiceImpl.java b/zanata-war/src/main/java/org/zanata/service/impl/TranslationServiceImpl.java
@@ -307,12 +307,12 @@ private void signalPostTranslateEvent(HTextFlowTarget hTextFlowTarget) {
 
             Events.instance()
                     .raiseTransactionSuccessEvent(
-                            TextFlowTargetStateEvent.EVENT_NAME,
-                            new TextFlowTargetStateEvent(document.getId(),
-                                    textFlow.getId(), hTextFlowTarget
-                                            .getLocale().getLocaleId(),
-                                    hTextFlowTarget.getId(), hTextFlowTarget
-                                            .getState()));
+                        TextFlowTargetStateEvent.EVENT_NAME,
+                        new TextFlowTargetStateEvent(document.getId(),
+                            textFlow.getId(), hTextFlowTarget
+                            .getLocale().getLocaleId(),
+                            hTextFlowTarget.getId(), hTextFlowTarget
+                            .getState()));
         }
     }
 
@@ -656,10 +656,14 @@ protected Boolean work() throws Exception {
                                         "skipping TextFlowTarget {} with unknown sourceHash: {}",
                                         resId, sourceHash);
                             } else {
+                                HProjectIteration iterationReloaded =
+                                        projectIterationDAO
+                                                .findById(hProjectIteration
+                                                    .getId());
                                 String validationMessage =
                                         validateTranslations(
                                                 incomingTarget.getState(),
-                                                hProjectIteration,
+                                                iterationReloaded,
                                                 incomingTarget.getResId(),
                                                 textFlow.getContents(),
                                                 incomingTarget.getContents());