Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Commit

Permalink
Add test for uploading a part to an old upload.
Browse files Browse the repository at this point in the history
  • Loading branch information
davidmason committed Aug 19, 2013
1 parent 026aa22 commit ea5daca
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 1 deletion.
Expand Up @@ -14,6 +14,7 @@
import org.mockito.Mock;
import org.zanata.common.EntityStatus;
import org.zanata.dao.DocumentDAO;
import org.zanata.dao.DocumentUploadDAO;
import org.zanata.dao.ProjectIterationDAO;
import org.zanata.model.HDocument;
import org.zanata.model.HProject;
Expand All @@ -32,6 +33,7 @@ public class DocumentUploadTest
protected SeamAutowire seam = SeamAutowire.instance();

@Mock protected DocumentDAO documentDAO;
@Mock protected DocumentUploadDAO documentUploadDAO;
@Mock protected ZanataIdentity identity;
@Mock protected ProjectIterationDAO projectIterationDAO;

Expand Down
Expand Up @@ -27,11 +27,14 @@

import org.hibernate.Session;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
import org.zanata.common.EntityStatus;
import org.zanata.dao.DocumentUploadDAO;
import org.zanata.exception.ChunkUploadException;
import org.zanata.model.HDocumentUpload;
import org.zanata.service.TranslationFileService;

@Test(groups = { "unit-tests" })
Expand All @@ -53,6 +56,7 @@ public void beforeEachMethod()
.use("identity", identity)
.use("session", session)
.use("documentDAO", documentDAO)
.use("documentUploadDAO", documentUploadDAO)
.use("projectIterationDAO", projectIterationDAO)
.use("translationFileService", translationFileService)
.use("uploadPartPersistService", uploadPartPersistService)
Expand Down Expand Up @@ -237,7 +241,24 @@ public void subsequentPartNoUploadId()
}
}

// TODO damason: test not first part but no existing upload
public void subsequentPartUploadNotPresent()
{
conf = defaultUpload().first(false).uploadId(5L).build();
mockLoggedIn();
mockProjectAndVersionStatus();
Mockito.when(documentUploadDAO.findById(conf.uploadId)).thenReturn(null);

try
{
util.failIfUploadNotValid(conf.id, conf.uploadForm);
}
catch (ChunkUploadException e)
{
assertThat(e.getStatusCode(), is(PRECONDITION_FAILED));
assertThat(e.getMessage(), is("No incomplete uploads found for uploadId '5'."));
}
}

// TODO damason: test not first part but docId does not match existing upload

// TODO damason: test returning correct stream depending whether file exists
Expand Down

0 comments on commit ea5daca

Please sign in to comment.